Issue 5635 - Implement website-default navbar component

static/scss/_navbar.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 /*******************************************************************************
  * Navbar component
  ******************************************************************************/
 
-.navbar .container
+.navbar
 {
-  display: table;
-  width: 100%;

[ire, 2017/11/02 11:15:28]

For some reason this didn't work when it was the other way around, i.e.
$large-desktop-width as `width` and 100% as `max-width`. 

If we decide to go with this method for the .navbar, we can just change the
.container to work this way instead since it's essentially the same for the
other elements.

[juliandoucette, 2017/11/02 13:31:23]

Acknowledged.

-  max-width: $large-desktop-width;
+  @extend .clearfix;
 }
 
-.navbar button
+/* .navbar .navbar-container
+ ****************************************************************************/
+
+.navbar-container
 {
-  color: inherit;
+  @if ($add-horizontal-navbar-padding)
+  {
+    @extend .container;
+  }
+  @else
+  {
+    @include container($container-width, 0px);
+  }
 }
 
-.navbar-branding,
-.toggle-navbar-collapse,
-.navbar-collapse
+/* .navbar .navbar-branding
+ ****************************************************************************/
+
+.navbar-branding
 {
-  display: table-cell;
-  padding-top: $small-space;
-  padding-bottom: $small-space;
-  vertical-align: middle;
+  padding-top: $navbar-padding + ($navbar-padding / 4);
+  padding-bottom: $navbar-padding + ($navbar-padding / 4);
+  line-height: 1;
+
+  @if ($add-horizontal-navbar-padding != true)
+  {
+    padding-right: $navbar-padding;
+    padding-left: $navbar-padding;
+  }
+}
+
+.navbar-branding img
+{
+  height: $navbar-branding-height;
+  vertical-align: text-top;
 }
 
 /* .navbar .toggle-navbar-collapse
  ****************************************************************************/
 
 .toggle-navbar-collapse
 {
   display: none;
+  padding-top: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+  padding-bottom: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+
+  @if ($add-horizontal-navbar-padding != true)
+  {
+    padding-right: $navbar-padding;
+    padding-left: $navbar-padding;
+  }
 }
 
 .js .toggle-navbar-collapse
 {
-  display: table-cell;
+  display: block;
 
   @media (min-width: $tablet-breakpoint)
   {
     display: none;
   }
 }
 
-.toggle-navbar-collapse button
-{
-  min-width: 100px;
-  border: 0;
-  background-color: transparent;
-  cursor: pointer;
-}
-
-.js .toggle-navbar-collapse .close-label
-{
-  display: none;
-}
-
-.expanded .toggle-navbar-collapse .open-label
-{
-  display: none;
-}
-
-.expanded .toggle-navbar-collapse .close-label
-{
-  display: inline;
-}
-
 /* .navbar .navbar-collapse
  ****************************************************************************/
 
 .navbar-collapse
 {
-  display: table-row;
-  text-align: left;
+  clear: both;
 
   @media (min-width: $tablet-breakpoint)
   {
-    display: table-cell;
-    text-align: right;
+    float: right;
+    clear: none;
   }
 }
 
 [dir="rtl"] .navbar-collapse
 {
-  text-align: right;
-
-  @media (min-width: $tablet-breakpoint)
-  {
-    text-align: left;
-  }
+  float: left;
 }
 
 .js .navbar-collapse
 {
   display: none;
 
   @media (min-width: $tablet-breakpoint)
   {
-    display: table-cell;
+    display: block;
   }
 }
 
 .expanded .navbar-collapse
 {
-  display: table-row;
-}
+  display: block;
+  width: 100%;
 
-.no-js .navbar-collapse:after,
-.expanded .navbar-collapse:after

[ire, 2017/11/02 11:15:28]

This is the only way I could think of to add bottom spacing to the
navbar-collapse

[juliandoucette, 2017/11/02 13:31:23]

You could add padding to the nav within instead.

-{
-  @media (max-width: $tablet-breakpoint + 1px)
+  @media (min-width: $tablet-breakpoint)
   {
-    display: block;
-    height: $small-space;
-    content: "";
+    width: auto;
   }
 }
 
+/* .navbar .navbar-nav
+ ****************************************************************************/
+
+@if ($add-horizontal-navbar-padding)
+{
+  .navbar .navbar-nav
+  {
+    padding-bottom: $navbar-padding / 2;
+
+    @media (min-width: $tablet-breakpoint)
+    {
+      margin-right: -($navbar-padding / 2);
+      margin-left: -($navbar-padding / 2);
+      padding-bottom: 0;
+    }
+  }
+}
+
+.navbar .navbar-nav li
+{
+  @media (min-width: $tablet-breakpoint)
+  {
+    display: inline-block;
+  }
+}
+
+.navbar .navbar-nav a
+{
+  display: block;
+  padding-top: $navbar-padding / 2;
+  padding-bottom: $navbar-padding / 2;
+
+  @if ($add-horizontal-navbar-padding != true)
+  {
+    padding-right: $navbar-padding;
+    padding-left: $navbar-padding;
+  }
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    padding-top: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+    padding-right: $navbar-padding / 2;
+    padding-bottom: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+    padding-left: $navbar-padding / 2;
+  }
+}