Delta Between Two Patch Sets: includes/components/navbar.html
Issue 29587584:
Issue 5635 - Implement website-default navbar component (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Demo of both methods
Created Nov. 6, 2017, 8:18 a.m.
Right Patch Set: Rebase
Created Jan. 4, 2018, 7:40 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
pages/index.html » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <div id="table-navbar"> | |
| 2 <div class="navbar bg-primary"> | 1 <div class="navbar bg-primary"> |
| 3 <div class="container"> | 2 <div class="navbar-container"> |
| 4 <a href="index" class="navbar-branding text-start">Website<br> Defaults</a> | 3 <a href="index" class="navbar-branding float-start"> |
| 4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo"> | |
| 5 </a> | |
| 5 | 6 |
| 6 <div class="toggle-navbar-collapse text-end"> | 7 <button class="toggle-navbar-collapse button-link float-end"> |
| 7 <button> | 8 Toggle Menu |
| 8 <span class="open-label">Open</span> | 9 </button> |
| 9 <span class="sr-only">/</span> | |
| 10 <span class="close-label">Close</span> | |
| 11 Menu | |
| 12 </button> | |
| 13 </div> | |
| 14 | 10 |
| 15 <div class="navbar-collapse"> | 11 <nav class="navbar-nav navbar-collapse"> |
| 16 <nav> | 12 <ul> |
| 17 <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</ a>, <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</a> | 13 <li><a href="index">Navbar Menu Link</a></li> |
| 18 </nav> | 14 <li><a href="index">Navbar Menu Link</a></li> |
| 19 </div> | 15 <li><a href="index">Navbar Menu Link</a></li> |
| 16 <li><a href="index">Navbar Menu Link</a></li> | |
| 17 </ul> | |
| 18 </nav> | |
| 20 </div> | 19 </div> |
| 21 </div> | 20 </div> |
| 22 </div> | |
| 23 | |
| 24 <br> | |
| 25 | |
| 26 <div id="floated-navbar"> | |
| 27 <div class="navbar bg-primary"> | |
| 28 <div class="container"> | |
| 29 <a href="index" class="navbar-branding float-start">Website<br> Defaults</a> | |
| 30 | |
| 31 <div class="toggle-navbar-collapse float-end"> | |
| 32 <button> | |
| 33 <span class="open-label">Open</span> | |
| 34 <span class="sr-only">/</span> | |
| 35 <span class="close-label">Close</span> | |
| 36 Menu | |
| 37 </button> | |
| 38 </div> | |
| 39 | |
| 40 <div class="navbar-collapse"> | |
| 41 <nav> | |
| 42 <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</ a>, <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</a> | |
| 43 </nav> | |
| 44 </div> | |
| 45 </div> | |
| 46 </div> | |
| 47 </div> | |
| LEFT | RIGHT |
« no previous file
|
pages/index.html » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
