Issue 5635 - Implement website-default navbar component

static/scss/_navbar.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 /*******************************************************************************
  * Navbar component
  ******************************************************************************/
 
 .navbar
 {
   @extend .clearfix;
 }
 
-.toggle-navbar-collapse,
-.navbar-collapse
+/* .navbar .navbar-container
+ ****************************************************************************/
+
+.navbar-container
 {
-  padding-top: $navbar-padding-v + ($navbar-padding-v / 2);
-  padding-bottom: $navbar-padding-v + ($navbar-padding-v / 2);
+  @if ($add-horizontal-navbar-padding)
+  {
+    @extend .container;
+  }
+  @else
+  {
+    @include container($container-width, 0px);
+  }
 }
 
 /* .navbar .navbar-branding
  ****************************************************************************/
 
 .navbar-branding
 {
-  padding-top: $navbar-padding-v;
-  padding-bottom: $navbar-padding-v;
+  padding-top: $navbar-padding + ($navbar-padding / 4);
+  padding-bottom: $navbar-padding + ($navbar-padding / 4);
+  line-height: 1;
+
+  @if ($add-horizontal-navbar-padding != true)
+  {
+    padding-right: $navbar-padding;
+    padding-left: $navbar-padding;
+  }
 }
 
 .navbar-branding img
 {
   height: $navbar-branding-height;
   vertical-align: text-top;
 }
 
 /* .navbar .toggle-navbar-collapse
  ****************************************************************************/
 
 .toggle-navbar-collapse
 {
-  @extend .unstyled;
   display: none;
-  cursor: pointer;
+  padding-top: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+  padding-bottom: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+
+  @if ($add-horizontal-navbar-padding != true)
+  {
+    padding-right: $navbar-padding;
+    padding-left: $navbar-padding;
+  }
 }
 
 .js .toggle-navbar-collapse
 {
   display: block;
 
   @media (min-width: $tablet-breakpoint)
   {
     display: none;
   }
 }
 
-.js .toggle-navbar-collapse .close-label
-{
-  display: none;
-}
-
-.expanded .toggle-navbar-collapse .open-label
-{
-  display: none;
-}
-
-.expanded .toggle-navbar-collapse .close-label
-{
-  display: inline;
-}
-
 /* .navbar .navbar-collapse
  ****************************************************************************/
 
 .navbar-collapse
 {
   clear: both;
-  padding-top: 0;
 
   @media (min-width: $tablet-breakpoint)
   {
     float: right;
     clear: none;
-    padding-top: $navbar-padding-v + ($navbar-padding-v / 2);
   }
 }
 
 [dir="rtl"] .navbar-collapse
 {
   float: left;
 }
 
 .js .navbar-collapse
 {
   display: none;
 
   @media (min-width: $tablet-breakpoint)
   {
     display: block;
   }
 }
 
 .expanded .navbar-collapse
 {
   display: block;
   width: 100%;
-}
-
-/* .navbar .nav
- ****************************************************************************/
-
-.navbar .navbar-nav li
-{
-  margin-bottom: $navbar-padding-v;

[juliandoucette, 2017/11/15 12:56:42]

It's inconvenient that you chose to use margin-bottom here instead of padding
top and bottom because this margin must be overridden in order to create a list
with background-color hover state. Margin-bottom works well for this example
because the navbar and the navbar-collapse are the same color. If they were not,
then there would obviously be space missing above the first link. 

[ire, 2017/11/30 14:01:18]

Done.

 
   @media (min-width: $tablet-breakpoint)
   {
-    display: inline-block;
-    margin: 0 0 0 $navbar-padding-v;
+    width: auto;
   }
 }
 
-[dir="rtl"] .navbar .navbar-nav li
+/* .navbar .navbar-nav
+ ****************************************************************************/
+
+@if ($add-horizontal-navbar-padding)
+{
+  .navbar .navbar-nav
+  {
+    padding-bottom: $navbar-padding / 2;
+
+    @media (min-width: $tablet-breakpoint)
+    {
+      margin-right: -($navbar-padding / 2);
+      margin-left: -($navbar-padding / 2);
+      padding-bottom: 0;
+    }
+  }
+}
+
+.navbar .navbar-nav li
 {
   @media (min-width: $tablet-breakpoint)
   {
     display: inline-block;
-    margin: 0 $navbar-padding-v 0 0;
   }
-}
-
-.navbar .navbar-nav li:last-child

[juliandoucette, 2017/11/15 12:56:42]

Why use the paren't padding instead of the child's margin here?

[ire, 2017/11/30 14:01:19]

Done.

-{
-  margin-bottom: 0;
 }
 
 .navbar .navbar-nav a
 {
   display: block;
+  padding-top: $navbar-padding / 2;
+  padding-bottom: $navbar-padding / 2;
+
+  @if ($add-horizontal-navbar-padding != true)
+  {
+    padding-right: $navbar-padding;
+    padding-left: $navbar-padding;
+  }
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    padding-top: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+    padding-right: $navbar-padding / 2;
+    padding-bottom: ($navbar-branding-height / 2) + ($navbar-padding / 2);
+    padding-left: $navbar-padding / 2;
+  }
 }