Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/components/navbar.html

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Use padding on navbar link, optimise svg Created Nov. 30, 2017, 2 p.m.
Right Patch Set: Rebase Created Jan. 4, 2018, 7:40 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/index.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <div class="navbar bg-primary"> 1 <div class="navbar bg-primary">
2 <div class="container"> 2 <div class="navbar-container">
3 <a href="index" class="navbar-branding float-start"> 3 <a href="index" class="navbar-branding float-start">
4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo"> 4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo">
5 </a> 5 </a>
6 6
7 <button class="toggle-navbar-collapse float-end"> 7 <button class="toggle-navbar-collapse button-link float-end">
8 <span class="open-label">Open</span> 8 Toggle Menu
juliandoucette 2017/12/01 16:30:43 It seems like a toggle button will be common to al
ire 2017/12/08 10:42:21 You're right. Done.
9 <span class="sr-only">/</span>
juliandoucette 2017/12/01 16:30:43 I don't think that this makes sense. - If .open-l
ire 2017/12/08 10:42:21 Yeah I think I didn't get this correctly. It's no
10 <span class="close-label">Close</span>
11 Menu
12 </button> 9 </button>
13 10
14 <nav class="navbar-nav navbar-collapse"> 11 <nav class="navbar-nav navbar-collapse">
15 <ul> 12 <ul>
16 <li><a href="index">Navbar Menu Link</a></li> 13 <li><a href="index">Navbar Menu Link</a></li>
17 <li><a href="index">Navbar Menu Link</a></li> 14 <li><a href="index">Navbar Menu Link</a></li>
18 <li><a href="index">Navbar Menu Link</a></li> 15 <li><a href="index">Navbar Menu Link</a></li>
19 <li><a href="index">Navbar Menu Link</a></li> 16 <li><a href="index">Navbar Menu Link</a></li>
20 </ul> 17 </ul>
21 </nav> 18 </nav>
22 </div> 19 </div>
23 </div> 20 </div>
LEFTRIGHT
« no previous file | pages/index.html » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld