Unified Diff: includes/components/navbar.html
Issue 29587584:
Issue 5635 - Implement website-default navbar component (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Demo - Use table layout
Created Nov. 2, 2017, 11:08 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
pages/index.html » ('j')
|
pages/navbar.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: includes/components/navbar.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/includes/components/navbar.html |
| @@ -0,0 +1,20 @@ |
| +<div class="navbar bg-primary"> |
| + <div class="container"> |
| + <a href="index" class="navbar-branding text-start">Website<br> Defaults</a> |
|
ire
2017/11/02 11:15:28
I added this line break to simulate the height of
juliandoucette
2017/11/02 13:31:22
Acknowledged.
|
| + |
| + <div class="toggle-navbar-collapse text-end"> |
|
ire
2017/11/02 11:15:28
Had to add a container because display: table-cell
juliandoucette
2017/11/02 13:31:22
Acknowledged.
|
| + <button> |
| + <span class="open-label">Open</span> |
| + <span class="sr-only">/</span> |
| + <span class="close-label">Close</span> |
| + Menu |
| + </button> |
| + </div> |
| + |
| + <div class="navbar-collapse"> |
| + <nav> |
| + <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</a> |
|
ire
2017/11/02 11:15:28
Added more links for testing, even though I know i
juliandoucette
2017/11/02 13:31:23
Acknowledged.
|
| + </nav> |
| + </div> |
| + </div> |
| +</div> |
« no previous file with comments
|
« no previous file
|
pages/index.html » ('j')
|
pages/navbar.md » ('J')
