Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29587596: Noissue - Address eslint warnings in the issue reporter (Closed)

Created:
Oct. 24, 2017, 10:37 a.m. by Wladimir Palant
Modified:
Oct. 24, 2017, 2:12 p.m.
Reviewers:
Manish Jethani, kzar
CC:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockplusui
Visibility:
Public.

Description

Noissue - Address eslint warnings in the issue reporter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M issue-reporter.js View 1 8 chunks +36 lines, -23 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Oct. 24, 2017, 10:37 a.m. (2017-10-24 10:37:32 UTC) #1
Manish Jethani
https://codereview.adblockplus.org/29587596/diff/29587597/issue-reporter.js File issue-reporter.js (right): https://codereview.adblockplus.org/29587596/diff/29587597/issue-reporter.js#newcode362 issue-reporter.js:362: "filters_subscription_lastDownload_connectionError" Even though ESLint complain I think this is ...
Oct. 24, 2017, 12:04 p.m. (2017-10-24 12:04:14 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29587596/diff/29587597/issue-reporter.js File issue-reporter.js (right): https://codereview.adblockplus.org/29587596/diff/29587597/issue-reporter.js#newcode362 issue-reporter.js:362: "filters_subscription_lastDownload_connectionError" On 2017/10/24 12:04:14, Manish Jethani wrote: > Even ...
Oct. 24, 2017, 12:17 p.m. (2017-10-24 12:17:27 UTC) #3
Manish Jethani
LGTM
Oct. 24, 2017, 12:21 p.m. (2017-10-24 12:21:43 UTC) #4
kzar
Oct. 24, 2017, 2:03 p.m. (2017-10-24 14:03:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld