dependencies - Issue 29587623: Issue 5925 - Update adblockplusui dependency to update strings and use checkboxes for Acceptable Ads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29587623: Issue 5925 - Update adblockplusui dependency to update strings and use checkboxes for Acceptable Ads (Closed)

Left Patch Set: Created Oct. 24, 2017, 12:09 p.m.

Right Patch Set: Updated the dependencies and moved resources to the metadata.chrome Created Oct. 26, 2017, 2:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:ebdc3801dd98 git:064a3ca	3 buildtools = buildtools hg:d9e351869c30 git:076d960

4 adblockpluscore = adblockpluscore hg:b21bddce2678 git:2b57122	4 adblockpluscore = adblockpluscore hg:b21bddce2678 git:2b57122

5 adblockplusui = adblockplusui hg:a65aba31839f git:a315379	5 adblockplusui = adblockplusui hg:0cc24b2b5ded git:915236b
kzar 2017/10/24 16:54:13 I updated the issue, perhaps we should update it t I updated the issue, perhaps we should update it to hg:e7371d9c682d git:99d9004 in order to include Wlaidmir's recent issue reporter improvements? saroyanm 2017/10/24 17:04:49 I think there might more coming till tomorrow. Let Show quoted text On 2017/10/24 16:54:13, kzar wrote: > I updated the issue, perhaps we should update it to hg:e7371d9c682d git:99d9004 > in order to include Wlaidmir's recent issue reporter improvements? I think there might more coming till tomorrow. Let's update the dependency tomorrow. We will have our regular weekly ABPUI meeting tomorrow 12:00CEST (I'll ask Winsley to add you as an optional participant), Winsley who manages the project(New options page) will be there as well(he is currently on vacation), I'll update the issue or ask him update the issue accordingly after the meeting tomorrow. saroyanm 2017/10/24 17:13:15 Anyway I've updated the dependencies to keep in sy Show quoted text On 2017/10/24 17:04:49, saroyanm wrote: > On 2017/10/24 16:54:13, kzar wrote: > > I updated the issue, perhaps we should update it to hg:e7371d9c682d > git:99d9004 > > in order to include Wlaidmir's recent issue reporter improvements? > > I think there might more coming till tomorrow. > Let's update the dependency tomorrow. > > We will have our regular weekly ABPUI meeting tomorrow 12:00CEST (I'll ask > Winsley to add you as an optional participant), Winsley who manages the > project(New options page) will be there as well(he is currently on vacation), > I'll update the issue or ask him update the issue accordingly after the meeting > tomorrow. Anyway I've updated the dependencies to keep in sync with the ticket description. saroyanm 2017/10/24 17:15:43 Scratch that: the meeting is moved to the Thursday Show quoted text On 2017/10/24 17:13:15, saroyanm wrote: > On 2017/10/24 17:04:49, saroyanm wrote: > > On 2017/10/24 16:54:13, kzar wrote: > > > I updated the issue, perhaps we should update it to hg:e7371d9c682d > > git:99d9004 > > > in order to include Wlaidmir's recent issue reporter improvements? > > > > I think there might more coming till tomorrow. > > Let's update the dependency tomorrow. > > > > We will have our regular weekly ABPUI meeting tomorrow 12:00CEST (I'll ask > > Winsley to add you as an optional participant), Winsley who manages the > > project(New options page) will be there as well(he is currently on vacation), > > I'll update the issue or ask him update the issue accordingly after the > meeting > > tomorrow. > > Anyway I've updated the dependencies to keep in sync with the ticket > description. Scratch that: the meeting is moved to the Thursday, so yes if we will have the Go by tomorrow I'll push this changes.
LEFT	RIGHT