Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29587645: Issue 5904 - Avoid include.preload.js running twice (Closed)

Created:
Oct. 24, 2017, 12:57 p.m. by kzar
Modified:
Oct. 24, 2017, 4:22 p.m.
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 5904 - Avoid include.preload.js running twice

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M composer.postload.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M include.preload.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 Like Manish mentioned, there might be a way to achieve this using ...
Oct. 24, 2017, 1 p.m. (2017-10-24 13:00:14 UTC) #1
Manish Jethani
LGTM https://codereview.adblockplus.org/29587645/diff/29587646/composer.postload.js File composer.postload.js (right): https://codereview.adblockplus.org/29587645/diff/29587646/composer.postload.js#newcode21 composer.postload.js:21: // here, but that would result in include.preload ...
Oct. 24, 2017, 4:01 p.m. (2017-10-24 16:01:37 UTC) #2
kzar
Oct. 24, 2017, 4:19 p.m. (2017-10-24 16:19:17 UTC) #3
Patch Set 2 : Fixed typo in comment

https://codereview.adblockplus.org/29587645/diff/29587646/composer.postload.js
File composer.postload.js (right):

https://codereview.adblockplus.org/29587645/diff/29587646/composer.postload.j...
composer.postload.js:21: // here, but that would result in include.preload
running both both at pre
On 2017/10/24 16:01:37, Manish Jethani wrote:
> Nit: "both both"

Done.

Powered by Google App Engine
This is Rietveld