Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: composer.postload.js

Issue 29587645: Issue 5904 - Avoid include.preload.js running twice (Closed)
Left Patch Set: Created Oct. 24, 2017, 12:57 p.m.
Right Patch Set: Fixed typo in comment Created Oct. 24, 2017, 4:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | include.preload.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 // We would rather export these properly and then require("include.preload") 20 // We would rather export these properly and then require("include.preload")
21 // here, but that would result in include.preload running both both at pre 21 // here, but that would result in include.preload running both at pre and post
Manish Jethani 2017/10/24 16:01:37 Nit: "both both"
kzar 2017/10/24 16:19:16 Done.
22 // and post load. 22 // load.
23 const {checkCollapse, elemhide, getURLsFromElement, typeMap} = window; 23 const {checkCollapse, elemhide, getURLsFromElement, typeMap} = window;
24 24
25 // The page ID for the popup filter selection dialog (top frame only). 25 // The page ID for the popup filter selection dialog (top frame only).
26 let blockelementPopupId = null; 26 let blockelementPopupId = null;
27 27
28 // Element picking state (top frame only). 28 // Element picking state (top frame only).
29 let currentlyPickingElement = false; 29 let currentlyPickingElement = false;
30 let lastMouseOverEvent = null; 30 let lastMouseOverEvent = null;
31 31
32 // During element picking this is the currently highlighted element. When 32 // During element picking this is the currently highlighted element. When
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 if (document instanceof HTMLDocument) 589 if (document instanceof HTMLDocument)
590 { 590 {
591 // There's a bug in Firefox that causes document_end content scripts to run 591 // There's a bug in Firefox that causes document_end content scripts to run
592 // before document_start content scripts on extension startup. In this case 592 // before document_start content scripts on extension startup. In this case
593 // the ext object is undefined, we fail to initialize, and initializeComposer 593 // the ext object is undefined, we fail to initialize, and initializeComposer
594 // returns false. As a workaround, try again after a timeout. 594 // returns false. As a workaround, try again after a timeout.
595 // https://bugzilla.mozilla.org/show_bug.cgi?id=1395287 595 // https://bugzilla.mozilla.org/show_bug.cgi?id=1395287
596 if (!initializeComposer()) 596 if (!initializeComposer())
597 setTimeout(initializeComposer, 2000); 597 setTimeout(initializeComposer, 2000);
598 } 598 }
LEFTRIGHT
« no previous file | include.preload.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld