Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: composer.postload.js

Issue 29587645: Issue 5904 - Avoid include.preload.js running twice (Closed)
Patch Set: Created Oct. 24, 2017, 12:57 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include.preload.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: composer.postload.js
diff --git a/composer.postload.js b/composer.postload.js
index b0a6f7f1b8047eba593c9e2b6183d2601111dc9f..2bc693210b895f946927ecce3a9070b1b0beeaf3 100644
--- a/composer.postload.js
+++ b/composer.postload.js
@@ -17,8 +17,10 @@
"use strict";
-const {checkCollapse, elemhide,
- getURLsFromElement, typeMap} = require("./include.preload");
+// We would rather export these properly and then require("include.preload")
+// here, but that would result in include.preload running both both at pre
Manish Jethani 2017/10/24 16:01:37 Nit: "both both"
kzar 2017/10/24 16:19:16 Done.
+// and post load.
+const {checkCollapse, elemhide, getURLsFromElement, typeMap} = window;
// The page ID for the popup filter selection dialog (top frame only).
let blockelementPopupId = null;
« no previous file with comments | « no previous file | include.preload.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld