#4612 - Enable External Commands in Nagios

modules/nagios/manifests/server.pp

 class nagios::server(
     $directory = hiera('nagios::server::directory', '/var/lib/nagios3'),

[mathias, 2017/10/25 16:53:42]

This technique is not necessary any more, we've been using it to emulate Puppet
3 behavior in Puppet 2. Today you can assign the default values directly, and
Puppet will worry about the Hiera lookup.

[f.nicolaisen, 2017/10/26 07:45:04]

Noted for next time!

     $domain,
     $certificate,
     $private_key,
     $is_default=false,
     $htpasswd_source,
     $admins,
     $zone,
     $contacts = hiera('nagios::server::contacts', {}),
     $contactgroups = hiera('nagios::server::contactgroups', {}),
     $commands = hiera('nagios::server::commands', {}),
@@ skipping 32 matching lines @@
   }
 
   spawn_fcgi::php_pool {'global':
     ensure => present,
     socket => '/tmp/php-fastcgi.sock',
     children => '3',
     require => Package['php5-cgi']
   }
 
   # See http://hub.eyeo.com/issues/4612#note-2
-  if $::operatingsystem == 'Debian' {

[mathias, 2017/10/25 14:40:55]

The condition should use $::osfamily, each associated OS should operate DPKG.

[f.nicolaisen, 2017/10/25 15:10:29]

Acknowledged.

+  if $::osfamily == 'Debian' {
 
     $dpkg_statoverride = 'dpkg-statoverride'
     $dpkg_options = shellquote(['nagios', 'nagios', '751', "$directory"])
     $dpkg_options_rw = shellquote(['nagios', 'www-data', '2710', "$directory/rw"])
 
     exec {"$directory":
       command => "$dpkg_statoverride --update --add $dpkg_options",
       unless => "$dpkg_statoverride --list $dpkg_options",
       path => ["/usr/bin/", "/bin/"],
       user => root,
@@ skipping 122 matching lines @@
     notify => Service['nagios3']
   }
 
   create_resources(nagios_contact, $contacts)
   create_resources(nagios_contactgroup, $contactgroups)
   create_resources(nagios_command, $commands)
   create_resources(nagios_service, $services)
   create_resources(nagios_host, $hosts)
   create_resources(nagios_hostgroup, $hostgroups)
 }