Issue 104 - added checktranslations function

localeTools.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import re
 import os
 import sys
 import codecs
 import json
 import urlparse
@@ skipping 282 matching lines @@
     # Remove any extra files
     for dir, files in dirs.iteritems():
         baseDir = os.path.join(localeConfig['base_path'], dir)
         if not os.path.exists(baseDir):
             continue
         for file in os.listdir(baseDir):
             path = os.path.join(baseDir, file)
             valid_extension = file.endswith('.json')
             if os.path.isfile(path) and valid_extension and not file in files:
                 os.remove(path)
+
+
+def check_translations(localeConfig):
+    base_path = localeConfig['base_path']
+    json_fld = path.rsplit('/', 1)[1]
+    for locale in os.listdir(base_path):
+        jsonpath = os.path.join(json_fld, locale, 'messages.json')
+
+        if not os.path.exists(jsonpath):
+            continue
+
+        with codecs.open(jsonpath, 'rb', encoding='utf-8') as f:
+            try:
+                data = json.load(f)
+            except ValueError, e:
+                print >>sys.stderr, '%s -> File is not valid.' + e

[tlucas, 2017/10/31 07:43:10]

? Does this even work?
I am expecting either .format() - or concatenating with "+", with the strings in
the correct order and without placeholders.

[erick, 2017/11/06 06:29:44]

Done.

+
+        for key, value in data.iteritems():
+            variables = set()
+            max_length = value.get('maxLength')
+            length = len(value['message'])
+            if max_length is not None and length > max_length or length > 160:
+                print >>sys.stderr, (
+                    '{} {} -> translation might be too long. More then 160 '
+                    'chars or maxLength exceeded').format(locale, key)
+
+            for match in re.finditer(r'\$(\S+?)\$', value['message']):
+                variables.add(match.group(1))
+            expected = set(value.get('placeholders', {}).iterkeys())
+            if variables != expected:
+                print >>sys.stderr, (
+                    '{} {}: Variables used are {} '
+                    'expected. Variables: {}'
+                    ).format(locale, key, variables, expected)