Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: localeTools.py

Issue 29587910: Issue 104 - added checktranslations function
Patch Set: Proposed changes Created Nov. 20, 2017, 11:39 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This Source Code Form is subject to the terms of the Mozilla Public 1 # This Source Code Form is subject to the terms of the Mozilla Public
2 # License, v. 2.0. If a copy of the MPL was not distributed with this 2 # License, v. 2.0. If a copy of the MPL was not distributed with this
3 # file, You can obtain one at http://mozilla.org/MPL/2.0/. 3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
4 4
5 import re 5 import re
6 import os 6 import os
7 import sys 7 import sys
8 import codecs 8 import codecs
9 import json 9 import json
10 import urlparse 10 import urlparse
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 # Remove any extra files 293 # Remove any extra files
294 for dir, files in dirs.iteritems(): 294 for dir, files in dirs.iteritems():
295 baseDir = os.path.join(localeConfig['base_path'], dir) 295 baseDir = os.path.join(localeConfig['base_path'], dir)
296 if not os.path.exists(baseDir): 296 if not os.path.exists(baseDir):
297 continue 297 continue
298 for file in os.listdir(baseDir): 298 for file in os.listdir(baseDir):
299 path = os.path.join(baseDir, file) 299 path = os.path.join(baseDir, file)
300 valid_extension = file.endswith('.json') 300 valid_extension = file.endswith('.json')
301 if os.path.isfile(path) and valid_extension and not file in files: 301 if os.path.isfile(path) and valid_extension and not file in files:
302 os.remove(path) 302 os.remove(path)
303
304
305 def check_translations(localeConfig):
306 base_path = localeConfig['base_path']
307 for locale in os.listdir(base_path):
308 jsonpath = os.path.join(base_path, locale, 'messages.json')
309
310 if not os.path.exists(jsonpath):
311 continue
312
313 with codecs.open(jsonpath, 'rb', encoding='utf-8') as f:
314 try:
315 data = json.load(f)
316 for key, value in data.iteritems():
317 variables = set()
318 max_length = value.get('maxLength')
319 length = len(value['message'])
320 if (max_length is not None
321 and length > max_length or length > 160):
322 print >>sys.stderr, (
323 '{} {} -> translation might be too long.'
324 'More then 160 chars or maxLength exceeded'
325 ).format(locale, key)
326
327 for match in re.finditer(r'\$(\S+?)\$', value['message']):
328 variables.add(match.group(1))
329 expected = set(value.get('placeholders', {}).iterkeys())
330 if variables != expected:
331 print >>sys.stderr, (
332 '{} {}: Variables used are {} '
333 'expected. Variables: {}'
334 ).format(locale, key, variables, expected)
335 except ValueError:
336 print >>sys.stderr, locale + ', messages.json is not valid.'
OLDNEW
« no previous file with comments | « build.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld