Issue 104 - added checktranslations function

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
 from getopt import getopt, GetoptError
@@ skipping 365 matching lines @@
     import buildtools.releaseAutomation as releaseAutomation
     releaseAutomation.run(baseDir, type, version, keyFile, downloadsRepo)
 
 
 def updatePSL(baseDir, scriptName, opts, args, type):
     import buildtools.publicSuffixListUpdater as publicSuffixListUpdater
     publicSuffixListUpdater.updatePSL(baseDir)
 
 
 def check_translations(baseDir, scriptName, opts, args, type):
+    from buildtools.packager import readMetadata
+    metadata = readMetadata(baseDir, type)
+
+    localeConfig = readLocaleConfig(baseDir, type, metadata)
+
     import buildtools.localeTools as localetools
-    localetools.check_translations(baseDir)
+    localetools.check_translations(localeConfig)
 
 
 with addCommand(lambda baseDir, scriptName, opts, args, type: usage(scriptName, type), ('help', '-h', '--help')) as command:
     command.shortDescription = 'Show this message'
 
 with addCommand(runBuild, 'build') as command:
     command.shortDescription = 'Create a build'
     command.description = 'Creates an extension build with given file name. If output_file is missing a default name will be chosen.'
     command.params = '[options] [output_file]'
     command.addOption('Use given build number (if omitted the build number will be retrieved from Mercurial)', short='b', long='build', value='num')
@@ skipping 41 matching lines @@
     command.addOption('Directory containing downloads repository (if omitted ../downloads is assumed)', short='d', long='downloads', value='dir')
     command.params = '[options] <version>'
     command.supportedTypes = {'chrome', 'edge'}
 
 with addCommand(updatePSL, 'updatepsl') as command:
     command.shortDescription = 'Updates Public Suffix List'
     command.description = 'Downloads Public Suffix List (see http://publicsuffix.org/) and generates lib/publicSuffixList.js from it.'
     command.supportedTypes = {'chrome'}
 
 with addCommand(check_translations, 'checktranslations') as command:
-    command.shortDescription = 'Checks translation files for overlong, missing and structure'

[tlucas, 2017/10/25 15:09:23]

nit: this line exceeds 79 characters
nit: "Checks translation files for overlong, missing and structure" -> maybe
"Checks translation files for structure and for overlong and missing
translations"

[erick, 2017/10/29 03:45:54]

Acknowledged.

-    command.description = 'JSON files translations will be checked by this functionality'

[tlucas, 2017/10/25 15:09:23]

nit: this line exceeds 79 characters
nit: description is shorter than shortDescription?
nit: Maybe something like "Perform translation checks" and switch this with
shortDescription

[erick, 2017/10/29 03:45:54]

Acknowledged.

+    command.shortDescription = 'Perform translation checks.'
+    command.description = 'Checks translations files for structure and for overlong translations.'
 
 
 def getType(baseDir, scriptName, args):
     # Look for an explicit type parameter (has to be the first parameter)
     if len(args) >= 2 and args[0] == '-t':
         type = args[1]
         del args[1]
         del args[0]
         if type not in knownTypes:
             print '''
@@ skipping 54 matching lines @@
                 if option in {'-h', '--help'}:
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)