Issue 5142 - Convert Element Hiding to C++

compiled/bindings/main.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 130 matching lines @@
         .function("getSubscriptionForFilter", &FilterStorage::GetSubscriptionForFilter)
         .function("addSubscription", &FilterStorage::AddSubscription)
         .function("removeSubscription", &FilterStorage::RemoveSubscription)
         .function("moveSubscription", &FilterStorage::MoveSubscription);
 
     class_<ElemHide_SelectorList>("ElemHide_SelectorList")
         .property("selectorCount", &ElemHide_SelectorList::GetSelectorCount)
         .function("selectorAt", &ElemHide_SelectorList::SelectorAt)
         .function("filterKeyAt", &ElemHide_SelectorList::FilterKeyAt);
 
-    singleton<ElemHide>("ElemHide", &ElemHide::GetInstance)

[sergei, 2018/01/15 15:31:19]

Could you please change it from singleton to a class with the regular lifetime?

[hub, 2018/01/16 02:57:39]

I can. 

This require a few other changes, ElemHideEmulation (still in JS) to take and
ElemHide parameter, at least in this patch.

+    class_<ElemHide>("ElemHide")
+        .class_function("create", &ElemHide::Create)
         .function("add", &ElemHide::Add)
         .function("remove", &ElemHide::Remove)
         .function("clear", &ElemHide::Clear)
         .function("getException", &ElemHide::GetException)
         .function("getSelectorsForDomain", &ElemHide::GetSelectorsForDomain)
         .function("getUnconditionalSelectors", &ElemHide::GetUnconditionalSelectors);
 
     printBindings();
     RegExpFilter::GenerateCustomBindings();
     FilterNotifier::GenerateCustomBindings();
 
     return 0;
   }
   catch (const std::exception& e)
   {
     EM_ASM_ARGS(
       console.error("Error occurred generating JavaScript bindings: " +
           Module.AsciiToString($0)), e.what()
     );
     return 1;
   }
 }