Unified Diff: compiled/filter/ActiveFilter.h
Issue 29587914:
Issue 5142 - Convert Element Hiding to C++ (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Re-added elemHide.js test. Fixed test failures related. Addresses review comments.
Created Jan. 19, 2018, 2:02 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« compiled/bindings/main.cpp ('k')
|
compiled/filter/ActiveFilter.cpp » ('j')
|
test/elemHide.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: compiled/filter/ActiveFilter.h |
| =================================================================== |
| --- a/compiled/filter/ActiveFilter.h |
| +++ b/compiled/filter/ActiveFilter.h |
| @@ -39,22 +39,24 @@ |
| {\ |
| FilterNotifier::FilterChange(FilterNotifier::Topic::topic, *this);\ |
| }\ |
| }\ |
| } |
| class ActiveFilter : public Filter |
| { |
| +public: |
| + typedef StringMap<bool> DomainMap; |
| + virtual DomainMap* GetDomains() const; |
| + static const DependentString DEFAULT_DOMAIN; |
| protected: |
| - typedef StringMap<bool> DomainMap; |
| typedef StringSet SitekeySet; |
| void ParseDomains(const String& domains, String::value_type separator) const; |
| void AddSitekey(const String& sitekey) const; |
| - virtual DomainMap* GetDomains() const; |
| virtual SitekeySet* GetSitekeys() const; |
| mutable std::unique_ptr<DomainMap> mDomains; |
| mutable std::unique_ptr<SitekeySet> mSitekeys; |
| private: |
| bool mIgnoreTrailingDot; |
| public: |
| static constexpr Type classType = Type::ACTIVE; |
| explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot); |
« no previous file with comments
|
« compiled/bindings/main.cpp ('k')
|
compiled/filter/ActiveFilter.cpp » ('j')
|
test/elemHide.js » ('J')
