Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/scss/content/_typography.scss

Issue 29588588: Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Oct. 25, 2017, 10:21 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 font-size: $font-size-h4; 45 font-size: $font-size-h4;
46 font-weight: $bold-weight; 46 font-weight: $bold-weight;
47 text-transform: uppercase; 47 text-transform: uppercase;
48 } 48 }
49 49
50 a 50 a
51 { 51 {
52 color: $font-color-link; 52 color: $font-color-link;
53 } 53 }
54 54
55 .heading-icon
56 {
57 height: 0.9em;
58 margin-right: 0.3em;
59 }
60
61 [dir="rtl"] .heading-icon
62 {
63 margin-right: 0;
64 margin-left: 0.3em;
65 }
66
67 .product-heading 55 .product-heading
68 { 56 {
69 @extend .h1; 57 @extend .h1;
70 @extend .section; 58 @extend .section;
71 @extend .ta-center; 59 @extend .ta-center;
72 } 60 }
73 61
74 .article-heading 62 .article-heading
75 { 63 {
76 @extend .h2; 64 @extend .h2;
65 width: 100%;
juliandoucette 2017/10/26 11:42:57 Why do we need this? (Headings are usually block.)
ire 2017/10/30 09:45:37 Because of the icon-container, it's display:table
juliandoucette 2017/10/31 14:14:34 Ack. But it's not anymore?
ire 2017/11/01 07:57:24 Oops missed that. Done.
77 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld