Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/article.tmpl

Issue 29588588: Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Rewrite .has-pre-icon Created Oct. 30, 2017, 9:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « static/scss/main.scss ('k') | templates/product-home.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends "templates/minimal" %} 1 {% extends "templates/minimal" %}
2 2
3 {% set product = products[product_id] %} 3 {% set product = products[product_id] %}
4 4
5 {% block body %} 5 {% block body %}
6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb">
7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList">
8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
9 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p roduct.slug }}"> 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}">
10 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate(product_id+"-logo-alt", "Image alt text") }}"> 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span>
11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span> 11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span>
12 </a> 12 </a>
13 <meta itemprop="position" content="1" /> 13 <meta itemprop="position" content="1" />
14 </li> 14 </li>
15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> 15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}" aria-current="page"> 16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}" aria-current="page">
17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span> 17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span>
18 </a> 18 </a>
19 <meta itemprop="position" content="2" /> 19 <meta itemprop="position" content="2" />
20 </li> 20 </li>
21 </ol> 21 </ol>
22 </nav> 22 </nav>
23 23
24 <main id="main" class="container clearfix"> 24 <main id="main" class="container clearfix">
25 <article class="article card {{ product_id }}-card section column two-thirds"> 25 <article class="article card {{ product_id }}-card section column two-thirds">
26 <h1 class="article-heading"> 26 <header class="article-heading">
27 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}"> 27 <h1 class="has-pre-icon">
28 28 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span>
29 {{ title | translate( get_page_name(page) + "-title", "Article title") } } 29 {{ title | translate( get_page_name(page) + "-title", "Article title") } }
ire 2017/10/30 09:46:41 This looks odd when the article title flows on to
juliandoucette 2017/10/31 14:14:35 Acknowledged.
ire 2017/11/01 07:57:25 https://issues.adblockplus.org/ticket/5963
30 </h1> 30 </h1>
31 31 </header>
32 {% if hide_browser_selector is not defined %}
33 <div class="article-browser-selector">
34 [Browser selector]
35 </div>
36 {% endif %}
37 32
38 <div class="article-body content"> 33 {% if hide_browser_selector is not defined %}
39 {{ body | safe }} 34 <div class="article-browser-selector">
40 </div> 35 [Browser selector]
36 </div>
37 {% endif %}
38
39 <div class="article-body content">
40 {{ body | safe }}
41 </div>
41 </article> 42 </article>
42 <aside class="section column one-third"> 43 <aside class="section column one-third">
43 <? include product-topics-accordion ?> 44 <? include product-topics-accordion ?>
44 </aside> 45 </aside>
45 </main> 46 </main>
46 47
47 <script id="no-content-for-platform-message" type="text/template"> 48 <script id="no-content-for-platform-message" type="text/template">
48 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> 49 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p>
49 </script> 50 </script>
50 {% endblock %} 51 {% endblock %}
51 52
52 {% block footer %} 53 {% block footer %}
53 <? include contact ?> 54 <? include contact ?>
54 {% endblock %} 55 {% endblock %}
OLDNEW
« no previous file with comments | « static/scss/main.scss ('k') | templates/product-home.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld