static/scss/content/_typography.scss - Issue 29588588: Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: static/scss/content/_typography.scss

Issue 29588588: Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Left Patch Set: Created Oct. 25, 2017, 10:21 a.m.

Right Patch Set: Rewrite .has-pre-icon Created Oct. 30, 2017, 9:44 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 // This file is part of help.eyeo.com.	1 // This file is part of help.eyeo.com.

2 // Copyright (C) 2017 Eyeo GmbH	2 // Copyright (C) 2017 Eyeo GmbH

3 //	3 //

4 // help.eyeo.com is free software: you can redistribute it and/or modify	4 // help.eyeo.com is free software: you can redistribute it and/or modify

5 // it under the terms of the GNU General Public License as published by	5 // it under the terms of the GNU General Public License as published by

6 // the Free Software Foundation, either version 3 of the License, or	6 // the Free Software Foundation, either version 3 of the License, or

7 // (at your option) any later version.	7 // (at your option) any later version.

8 //	8 //

9 // help.eyeo.com is distributed in the hope that it will be useful,	9 // help.eyeo.com is distributed in the hope that it will be useful,

10 // but WITHOUT ANY WARRANTY; without even the implied warranty of	10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 a	50 a

51 {	51 {

52 color: $font-color-link;	52 color: $font-color-link;

53 }	53 }

54	54

55 .product-heading	55 .product-heading

56 {	56 {

57 @extend .h1;	57 @extend .h1;

58 @extend .section;	58 @extend .section;

59 @extend .ta-center;	59 @extend .ta-center;

	60

	61 .has-pre-icon

	62 {

	63 display: inline-block;

	64 }

60 }	65 }

61	66

62 .article-heading	67 .article-heading

63 {	68 {

64 @extend .h2;	69 @extend .h2;

65 width: 100%;	70 width: 100%;
juliandoucette 2017/10/26 11:42:57 Why do we need this? (Headings are usually block.) Why do we need this? (Headings are usually block.) ire 2017/10/30 09:45:37 Because of the icon-container, it's display:table Show quoted text On 2017/10/26 11:42:57, juliandoucette wrote: > Why do we need this? (Headings are usually block.) Because of the icon-container, it's display:table juliandoucette 2017/10/31 14:14:34 Ack. But it's not anymore? Show quoted text On 2017/10/30 09:45:37, ire wrote: > On 2017/10/26 11:42:57, juliandoucette wrote: > > Why do we need this? (Headings are usually block.) > > Because of the icon-container, it's display:table Ack. But it's not anymore? ire 2017/11/01 07:57:24 Oops missed that. Done. Show quoted text On 2017/10/31 14:14:34, juliandoucette wrote: > On 2017/10/30 09:45:37, ire wrote: > > On 2017/10/26 11:42:57, juliandoucette wrote: > > > Why do we need this? (Headings are usually block.) > > > > Because of the icon-container, it's display:table > > Ack. But it's not anymore? Oops missed that. Done.
66 }	71 }

LEFT	RIGHT