Delta Between Two Patch Sets: templates/product-home.tmpl
Issue 29588588:
Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set:
Created Oct. 25, 2017, 10:21 a.m.
Right Patch Set: Rewrite .has-pre-icon
Created Oct. 30, 2017, 9:44 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« templates/article.tmpl ('K')
|
« templates/article.tmpl ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 {% extends "templates/minimal" %} | 1 {% extends "templates/minimal" %} |
| 2 | 2 |
| 3 {% set product = products[product_id] %} | 3 {% set product = products[product_id] %} |
| 4 | 4 |
| 5 {% block body %} | 5 {% block body %} |
| 6 <main id="main" class="container"> | 6 <main id="main" class="container"> |
| 7 <h1 class="product-heading aside-icon-container"> | 7 <header class="product-heading"> |
| 8 <img src="/img/png/logo-{{ product_id }}.png" srcset="/img/svg/logo-{{ produ ct_id }}.svg 2x" alt="{{ product.full_name+" Logo" | translate( product_id+"-log o-alt", "Image alt text") }}"> | 8 <h1 class="has-pre-icon"> |
| 9 | 9 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}"></s pan> |
| 10 <span>{{ product.full_name + " Help Center" | translate(product_id+"-help-ho me-title", "Page title") }}</span> | 10 {{ product.full_name + " Help Center" | translate(product_id+"-help-home-t itle", "Page title") }} |
| 11 </h1> | 11 </h1> |
| 12 </header> | |
| 12 | 13 |
| 13 {% set popular_topics = get_pages_metadata({ "product_id": product_id, "templa te": "article", "popular": "true" }) %} | 14 {% set popular_topics = get_pages_metadata({ "product_id": product_id, "templa te": "article", "popular": "true" }) %} |
| 14 {% if popular_topics %} | 15 {% if popular_topics %} |
| 15 <section class="card {{ product_id }}-card section"> | 16 <section class="card {{ product_id }}-card section"> |
| 16 <h2 class="card-heading aside-icon-container"> | 17 <h2 class="card-heading has-pre-icon"> |
| 17 <img src="/img/png/popular-icon.png" srcset="/img/svg/popular-icon.svg 2x" alt="{{ "Popular Icon" | translate("popular-icon-alt", "Image alt text") }}"> | 18 <span class="pre-icon" style="{{ get_inline_bg('popular-icon') }}"></span> |
| 18 | 19 {{ "Popular Topics" | translate("popular-topics-title", "Section title") } } |
| 19 <span>{{ "Popular Topics" | translate("popular-topics-title", "Section titl e") }}</span> | |
| 20 </h2> | 20 </h2> |
| 21 | 21 |
| 22 <ul class="underlined-list row"> | 22 <ul class="underlined-list row"> |
| 23 {% for article in popular_topics %} | 23 {% for article in popular_topics %} |
| 24 <li class="column one-half"> | 24 <li class="column one-half"> |
| 25 <a href="{{ article["page"] }}"> | 25 <a href="{{ article["page"] }}"> |
| 26 {{ article.title | translate( get_page_name( article["page"]) + "-titl e", "Article title") }} | 26 {{ article.title | translate( get_page_name( article["page"]) + "-titl e", "Article title") }} |
| 27 </a> | 27 </a> |
| 28 </li> | 28 </li> |
| 29 {% endfor %} | 29 {% endfor %} |
| 30 </ul> | 30 </ul> |
| 31 </section> | 31 </section> |
| 32 {% endif %} | 32 {% endif %} |
| 33 | 33 |
| 34 <div class="row"> | 34 <div class="row"> |
| 35 {% for category in product.help_categories %} | 35 {% for category in product.help_categories %} |
| 36 {% set articles = get_pages_metadata({ "product_id": product_id, "template": "article", "category": category.name }) %} | 36 {% set articles = get_pages_metadata({ "product_id": product_id, "template": "article", "category": category.name }) %} |
| 37 {% if articles and category.name != 'Popular Topics' %} | 37 {% if articles and category.name != 'Popular Topics' %} |
| 38 <section class="section column one-half"> | 38 <section class="section column one-half"> |
| 39 <h2 class="h4 aside-icon-container"> | 39 <h2 class="h4 has-pre-icon"> |
| 40 <img src="/img/png/{{ category.icon }}.png" srcset="/img/svg/{{ category .icon }}.svg 2x" alt="{{ category.name+" Icon" | translate(category.icon+"-alt", "Image alt text") }}"> | 40 <span class="pre-icon" style="{{ get_inline_bg(category.icon) }}"></span > |
| 41 | 41 {{ category.name | translate( category.slug + "-category-title", "Catego ry title") }} |
| 42 <span>{{ category.name | translate( category.slug + "-category-title", " Category title") }}</span> | |
| 43 </h2> | 42 </h2> |
| 44 | 43 |
| 45 <ul class="underlined-list"> | 44 <ul class="underlined-list"> |
| 46 {% for article in articles %} | 45 {% for article in articles %} |
| 47 <li> | 46 <li> |
| 48 <a href="{{ article["page"] }}"> | 47 <a href="{{ article["page"] }}"> |
| 49 {{ article.title | translate( get_page_name( article["page"]) + "-ti tle", "Article title") }} | 48 {{ article.title | translate( get_page_name( article["page"]) + "-ti tle", "Article title") }} |
| 50 </a> | 49 </a> |
| 51 </li> | 50 </li> |
| 52 {% endfor %} | 51 {% endfor %} |
| 53 </ul> | 52 </ul> |
| 54 </section> | 53 </section> |
| 55 {% endif %} | 54 {% endif %} |
| 56 {% endfor %} | 55 {% endfor %} |
| 57 </div> | 56 </div> |
| 58 | 57 |
| 59 </main> | 58 </main> |
| 60 {% endblock %} | 59 {% endblock %} |
| 61 | 60 |
| 62 {% block footer %} | 61 {% block footer %} |
| 63 <? include contact ?> | 62 <? include contact ?> |
| 64 {% endblock %} | 63 {% endblock %} |
| LEFT | RIGHT |
« templates/article.tmpl ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
