 Issue 29588588:
  Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29588588:
  Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Index: static/scss/components/_aside-icon.scss | 
| =================================================================== | 
| new file mode 100644 | 
| --- /dev/null | 
| +++ b/static/scss/components/_aside-icon.scss | 
| @@ -0,0 +1,40 @@ | 
| +// This file is part of help.eyeo.com. | 
| +// Copyright (C) 2017 Eyeo GmbH | 
| +// | 
| +// help.eyeo.com is free software: you can redistribute it and/or modify | 
| +// it under the terms of the GNU General Public License as published by | 
| +// the Free Software Foundation, either version 3 of the License, or | 
| +// (at your option) any later version. | 
| +// | 
| +// help.eyeo.com is distributed in the hope that it will be useful, | 
| +// but WITHOUT ANY WARRANTY; without even the implied warranty of | 
| +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 
| +// GNU General Public License for more details. | 
| +// | 
| +// You should have received a copy of the GNU General Public License | 
| +// along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. | 
| + | 
| +// Aside Icon ////////////////////////////////////////////////////////////////// | 
| 
ire
2017/10/25 10:23:01
I changed the name to .aside-icon from .heading-ic
 
juliandoucette
2017/10/26 11:42:57
suggest: `has-icon`, `has-pre-icon`, `pre-icon`, `
 
ire
2017/10/30 09:45:37
Done.
 
ire
2017/10/30 09:45:37
I like `has-pre-icon`
 | 
| + | 
| +.aside-icon-container | 
| +{ | 
| + display: table; | 
| +} | 
| + | 
| +.aside-icon-container span | 
| 
juliandoucette
2017/10/26 11:42:57
The icon still seems offcenter (too far up).
 
ire
2017/10/30 09:45:37
You're right. I rewrote this to use background-ima
 | 
| +{ | 
| + display: table-cell; | 
| + vertical-align: middle; | 
| +} | 
| + | 
| +.aside-icon-container img | 
| +{ | 
| + height: 0.9em; | 
| + margin-right: 0.3em; | 
| +} | 
| + | 
| +[dir="rtl"] .aside-icon-container img | 
| +{ | 
| + margin-right: 0; | 
| + margin-left: 0.3em; | 
| +} |