Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/product-home.tmpl

Issue 29588588: Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Rewrite .has-pre-icon Created Oct. 30, 2017, 9:44 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« templates/article.tmpl ('K') | « templates/article.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/product-home.tmpl
===================================================================
--- a/templates/product-home.tmpl
+++ b/templates/product-home.tmpl
@@ -1,26 +1,26 @@
{% extends "templates/minimal" %}
{% set product = products[product_id] %}
{% block body %}
<main id="main" class="container">
- <h1 class="product-heading">
- <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcset="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | translate( product_id+"-logo-alt", "Image alt text") }}">
-
- {{ product.full_name + " Help Center" | translate(product_id+"-help-home-title", "Page title") }}
- </h1>
+ <header class="product-heading">
+ <h1 class="has-pre-icon">
+ <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}"></span>
+ {{ product.full_name + " Help Center" | translate(product_id+"-help-home-title", "Page title") }}
+ </h1>
+ </header>
{% set popular_topics = get_pages_metadata({ "product_id": product_id, "template": "article", "popular": "true" }) %}
{% if popular_topics %}
<section class="card {{ product_id }}-card section">
- <h2 class="card-heading">
- <img class="heading-icon" src="/img/png/popular-icon.png" srcset="/img/svg/popular-icon.svg 2x" alt="{{ "Popular Icon" | translate("popular-icon-alt", "Image alt text") }}">
-
+ <h2 class="card-heading has-pre-icon">
+ <span class="pre-icon" style="{{ get_inline_bg('popular-icon') }}"></span>
{{ "Popular Topics" | translate("popular-topics-title", "Section title") }}
</h2>
<ul class="underlined-list row">
{% for article in popular_topics %}
<li class="column one-half">
<a href="{{ article["page"] }}">
{{ article.title | translate( get_page_name( article["page"]) + "-title", "Article title") }}
@@ -31,19 +31,18 @@
</section>
{% endif %}
<div class="row">
{% for category in product.help_categories %}
{% set articles = get_pages_metadata({ "product_id": product_id, "template": "article", "category": category.name }) %}
{% if articles and category.name != 'Popular Topics' %}
<section class="section column one-half">
- <h2 class="h4">
- <img class="heading-icon" src="/img/png/{{ category.icon }}.png" srcset="/img/svg/{{ category.icon }}.svg 2x" alt="{{ category.name+" Icon" | translate(category.icon+"-alt", "Image alt text") }}">
-
+ <h2 class="h4 has-pre-icon">
+ <span class="pre-icon" style="{{ get_inline_bg(category.icon) }}"></span>
{{ category.name | translate( category.slug + "-category-title", "Category title") }}
</h2>
<ul class="underlined-list">
{% for article in articles %}
<li>
<a href="{{ article["page"] }}">
{{ article.title | translate( get_page_name( article["page"]) + "-title", "Article title") }}
« templates/article.tmpl ('K') | « templates/article.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld