Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29588949: Issue 5877 - Account for random locale processing order (Closed)

Created:
Oct. 25, 2017, 2:16 p.m. by tlucas
Modified:
Oct. 25, 2017, 3:21 p.m.
Reviewers:
Sebastian Noack, kzar
CC:
saroyanm, rossg, Wladimir Palant
Visibility:
Public.

Description

Issue 5877 - Account for random locale processing order

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M packagerChrome.py View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 5
tlucas
Patch Set 1 Thanks Wladimir, for tracking down this bug! * Account for random locale ...
Oct. 25, 2017, 2:20 p.m. (2017-10-25 14:20:26 UTC) #1
kzar
LGTM
Oct. 25, 2017, 2:32 p.m. (2017-10-25 14:32:42 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29588949/diff/29588950/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29588949/diff/29588950/packagerChrome.py#newcode212 packagerChrome.py:212: filename = item[0] Nit: This temporary variable isnt necessary.
Oct. 25, 2017, 3:08 p.m. (2017-10-25 15:08:33 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29588949/diff/29588950/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29588949/diff/29588950/packagerChrome.py#newcode212 packagerChrome.py:212: filename = item[0] On 2017/10/25 15:08:33, Sebastian Noack wrote: ...
Oct. 25, 2017, 3:11 p.m. (2017-10-25 15:11:48 UTC) #4
Sebastian Noack
Oct. 25, 2017, 3:15 p.m. (2017-10-25 15:15:41 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld