cms-dev/tox.ini - Issue 29588962: Issue 5934 - CMS testing automation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: cms-dev/tox.ini

Issue 29588962: Issue 5934 - CMS testing automation (Closed)

Patch Set: Change the usage a bit, add some useful options, add a couple of tests Created Oct. 27, 2017, 5:38 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 [tox]

	2 envlist = py27,py35,py36,flake8

	3 skipsdist = true

	4

	5 [flake8]

	6 ignore = D1
	tlucas 2017/11/24 10:57:46 Do we want to keep ignoring all D1 errors in new c Do we want to keep ignoring all D1 errors in new code? While i agree that it would be overkill for tests, the actual API would IMHO benefit from it. (Besides, the only 2 D1 warnings in cmp_cms.py would be: cms_cmp.py:116:1: D107 Missing docstring in __init__ cms_cmp.py:159:1: D102 Missing docstring in public method ) Vasily Kuznetsov 2017/11/28 16:53:37 This is not really a public API, but I agree with Show quoted text On 2017/11/24 10:57:46, tlucas wrote: > Do we want to keep ignoring all D1 errors in new code? While i agree that it > would be overkill for tests, the actual API would IMHO benefit from it. > > (Besides, the only 2 D1 warnings in cmp_cms.py would be: > > cms_cmp.py:116:1: D107 Missing docstring in __init__ > cms_cmp.py:159:1: D102 Missing docstring in public method > ) This is not really a public API, but I agree with you and I would rather add missing docstrings and remove the ignore. Vasily Kuznetsov 2017/11/28 16:53:37 Done. Show quoted text On 2017/11/24 10:57:46, tlucas wrote: > Do we want to keep ignoring all D1 errors in new code? While i agree that it > would be overkill for tests, the actual API would IMHO benefit from it. > > (Besides, the only 2 D1 warnings in cmp_cms.py would be: > > cms_cmp.py:116:1: D107 Missing docstring in __init__ > cms_cmp.py:159:1: D102 Missing docstring in public method > ) Done.
	7

	8 [testenv]

	9 deps =

	10 pytest

	11 commands =

	12 pytest tests

	13

	14 [testenv:flake8]
	tlucas 2017/11/24 10:57:46 Something is screwy in here. running "$ tox" yiel Something is screwy in here. running "$ tox" yields no warnings at all, activating the flake8 environment generated by tox and running "$ flake8 cms-cmp.py tests" yields the following: ./cms_cmp.py:83:1: D202 No blank lines allowed after function docstring ./cms_cmp.py:203:1: D401 First line should be in imperative mood; try rephrasing Vasily Kuznetsov 2017/11/28 16:53:37 Done. Show quoted text On 2017/11/24 10:57:46, tlucas wrote: > Something is screwy in here. > > running "$ tox" yields no warnings at all, activating the flake8 environment > generated by tox and running "$ flake8 cms-cmp.py tests" yields the following: > > ./cms_cmp.py:83:1: D202 No blank lines allowed after function docstring > ./cms_cmp.py:203:1: D401 First line should be in imperative mood; try rephrasing Done.
	15 basepython = python3

	16 deps =

	17 flake8

	18 flake8-docstrings

	19 pep8-naming

	20 ../flake8-eyeo

	21 commands =

	22 flake8 cms-cmp.py tests

OLD	NEW

« cms-dev/tests/test_cms_cmp.py ('K') | « cms-dev/tests/test_cms_cmp.py ('k') | no next file » | no next file with comments »