Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29588973: Issue 5683 - Made og:url locale specific (Closed)

Created:
Oct. 25, 2017, 7:59 p.m. by juliandoucette
Modified:
Oct. 26, 2017, 3:04 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5683 - Made og:url locale specific

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M templates/default.tmpl View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4
juliandoucette
Oct. 25, 2017, 7:59 p.m. (2017-10-25 19:59:11 UTC) #1
ire
LGTM (One comment/SuperNIT) https://codereview.adblockplus.org/29588973/diff/29588974/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29588973/diff/29588974/templates/default.tmpl#newcode42 templates/default.tmpl:42: <meta property="og:url" content="{{ config.get("general", "siteurl") }}{{ ...
Oct. 26, 2017, 9:59 a.m. (2017-10-26 09:59:45 UTC) #2
juliandoucette
Thank you for the suggestion! See my response below. https://codereview.adblockplus.org/29588973/diff/29588974/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29588973/diff/29588974/templates/default.tmpl#newcode42 templates/default.tmpl:42: ...
Oct. 26, 2017, 11:31 a.m. (2017-10-26 11:31:41 UTC) #3
juliandoucette
Oct. 26, 2017, 3:04 p.m. (2017-10-26 15:04:05 UTC) #4

Powered by Google App Engine
This is Rietveld