Issue 5683 - Made og:url locale specific

templates/default.tmpl

Index: templates/default.tmpl
===================================================================
--- a/templates/default.tmpl
+++ b/templates/default.tmpl
@@ -34,17 +34,17 @@
       <meta property="og:description" content="{{ description | translate("description") }}">
     {% endif %}
     <meta property="og:locale" content="{{ locale | to_og_locale }}">
     {% for alternate_locale in available_locales %}
       {% if alternate_locale != locale %}
         <meta property="og:locale:alternate" content="{{ alternate_locale | to_og_locale }}">
       {% endif %}
     {% endfor %}
-    <meta property="og:url" content="{{ get_canonical_url(page | ignore_browsers) }}">
+    <meta property="og:url" content="{{ config.get("general", "siteurl") }}{{ source.resolve_link(page | ignore_browsers, locale)[1] }}">

[ire, 2017/10/26 09:59:45]

Didn't know about this `source.resolve_link()` function, cool! Is it a CMS thing
or a Jinja thing?

SuperNIT: I found a slightly shorter way to do this:

```
{{ config.get("general", "siteurl") }}/{{ locale }}/{{ page }}
```

I don't like that it requires adding "/" but I like that its easier to
understand/read at first glance. I also haven't tested this very extensively so
it may not be as robust as your method.

[juliandoucette, 2017/10/26 11:31:41]

See https://hg.adblockplus.org/cms/file/tip/cms/sources.py#l29
I don't like the way that this is done either. See
https://issues.adblockplus.org/ticket/5452 for suggested improvements. But [I
didn't want to wait for #5452, I think source.resolve_link is more reliable
because it performs several checks and can be extended].

 
     {# twitter https://dev.twitter.com/cards/markup #}
     <meta name="twitter:site" content="@AdblockPlus" />
     <meta name="twitter:creator" content="@AdblockPlus" />
 
     <link rel="stylesheet" href="/css/main.css" class="cssfx">
     <link rel="stylesheet" href="/css/main-desktop.css" media="(min-width: 1000px)" class="cssfx">
     <link rel="stylesheet" href="/css/main-mobile.css" media="(max-width: 1000px)">