Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 29588979: Issue 5651 - Set relative values for strong and small elements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by juliandoucette
Modified:
2 years, 3 months ago
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Issue 5651 - Set relative values for strong and small elements

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M static/scss/_reset.scss View 1 1 chunk +2 lines, -2 lines 0 comments Download
M static/scss/_variables.scss View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
2 years, 3 months ago (2017-10-25 20:24:21 UTC) #1
ire
Thanks Julian! 2 comments https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset.scss File static/scss/_reset.scss (right): https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset.scss#newcode146 static/scss/_reset.scss:146: font-size: 80%; Apparently the keyword ...
2 years, 3 months ago (2017-10-26 10:11:08 UTC) #2
juliandoucette
Done. https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset.scss File static/scss/_reset.scss (right): https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset.scss#newcode146 static/scss/_reset.scss:146: font-size: 80%; On 2017/10/26 10:11:08, ire wrote: > ...
2 years, 3 months ago (2017-10-26 11:25:50 UTC) #3
ire
LGTM https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset.scss File static/scss/_reset.scss (right): https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset.scss#newcode146 static/scss/_reset.scss:146: font-size: 80%; On 2017/10/26 11:25:50, juliandoucette wrote: > ...
2 years, 3 months ago (2017-10-26 12:45:27 UTC) #4
juliandoucette
2 years, 3 months ago (2017-10-26 15:00:18 UTC) #5

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5