Issue 5916 - Locale strings are broken in adblockpluschrome when building from Windows

packagerChrome.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import errno
 import glob
 import io
 import json
 import os
 import re
 import struct
 import subprocess
 import sys
 import random
+import posixpath
 
 from packager import (readMetadata, getDefaultFileName, getBuildVersion,
                       getTemplate, Files)
 
 defaultLocale = 'en_US'
 
 
 def getIgnoredFiles(params):
     return {'store.description'}
 
@@ skipping 182 matching lines @@
         files[bundle] = output['files'][bundle].encode('utf-8')
 
 
 def import_locales(params, files):
     for item in params['metadata'].items('import_locales'):
         filename = item[0]
         for sourceFile in glob.glob(os.path.join(os.path.dirname(item.source),
                                                  *filename.split('/'))):
             keys = item[1]
             locale = sourceFile.split(os.path.sep)[-2]
-            targetFile = os.path.join('_locales', locale, 'messages.json')
+            targetFile = posixpath.join('_locales', locale, 'messages.json')

[Oleksandr, 2017/10/26 09:16:02]

A more generic approach would be to not rely on any specific style of paths at
all. I have tried going that route, but it requires too many changes and
probably will be better done in another context/review.

[Wladimir Palant, 2017/10/26 09:22:13]

ZIP archives (which is what we are talking about here) are generally using POSIX
style paths so this approach looks good to me. 

             data = json.loads(files.get(targetFile, '{}').decode('utf-8'))
 
             try:
                 with io.open(sourceFile, 'r', encoding='utf-8') as handle:
                     sourceData = json.load(handle)
 
                 # Resolve wildcard imports
                 if keys == '*':
                     importList = sourceData.keys()
                     importList = filter(lambda k: not k.startswith('_'), importList)
@@ skipping 153 matching lines @@
     if devenv:
         add_devenv_requirements(files, metadata, params)
 
     zipdata = files.zipToString()
     signature = None
     pubkey = None
     if keyFile != None:
         signature = signBinary(zipdata, keyFile)
         pubkey = getPublicKey(keyFile)
     writePackage(outFile, pubkey, signature, zipdata)