Issue 5938 - Use top-level var for global variables

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 505 matching lines @@
     checkCollapse(event.target);
   }, true);
 
   document.addEventListener("load", event =>
   {
     let element = event.target;
     if (/^i?frame$/.test(element.localName))
       checkCollapse(element);
   }, true);
 }
-
-window.checkCollapse = checkCollapse;

[Manish Jethani, 2017/10/26 20:47:56]

This didn't really make sense, the variables are accessible in
composer.postload.js anyway.

[kzar, 2017/10/27 11:17:40]

Have you tested that? include.preload.js in the build is actually a webpack
bundle consisting of include.preload.js and inject.preload.js, so I would have
expected variables in here to be inaccessible from composer.postload.js.

[Manish Jethani, 2017/10/27 11:40:08]

I see, you're right, it doesn't actually work, and it looks like we have no
options here. Even when we add the custom loader, it'll have to work with the
window object.

-window.elemhide = elemhide;
-window.typeMap = typeMap;
-window.getURLsFromElement = getURLsFromElement;