Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: composer.postload.js

Issue 29589668: Issue 5938 - Use top-level var for global variables (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Oct. 26, 2017, 8:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ext/common.js » ('j') | include.preload.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: composer.postload.js
===================================================================
--- a/composer.postload.js
+++ b/composer.postload.js
@@ -10,22 +10,19 @@
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
-"use strict";
+/* globals checkCollapse, elemhide, getURLsFromElement, typeMap */
Manish Jethani 2017/10/26 20:47:56 This is back to where it was.
-// We would rather export these properly and then require("include.preload")
-// here, but that would result in include.preload running both at pre and post
-// load.
-const {checkCollapse, elemhide, getURLsFromElement, typeMap} = window;
+"use strict";
// The page ID for the popup filter selection dialog (top frame only).
let blockelementPopupId = null;
// Element picking state (top frame only).
let currentlyPickingElement = false;
let lastMouseOverEvent = null;
« no previous file with comments | « no previous file | ext/common.js » ('j') | include.preload.js » ('J')

Powered by Google App Engine
This is Rietveld