Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/createNightlies.py

Issue 29589674: Issue 5942 - don't create Gecko update manifests (Closed)
Patch Set: Removing further unused code Created Oct. 26, 2017, 10:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .sitescripts.example ('k') | sitescripts/extensions/bin/updateUpdateManifests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/createNightlies.py
diff --git a/sitescripts/extensions/bin/createNightlies.py b/sitescripts/extensions/bin/createNightlies.py
index 6db1d9c96337a4451f254d48364d96b36704605e..2dbad76e64d3f29bcce1d7c63543f820bf8539a3 100644
--- a/sitescripts/extensions/bin/createNightlies.py
+++ b/sitescripts/extensions/bin/createNightlies.py
@@ -175,17 +175,6 @@ class NightlyBuild(object):
self.version = packager.getBuildVersion(self.tempdir, metadata, False,
self.buildNum)
self.basename = metadata.get('general', 'basename')
- self.compat = []
- for key, value in packager.KNOWN_APPS.iteritems():
- if metadata.has_option('compat', key):
- minVersion, maxVersion = metadata.get('compat', key).split('/')
- self.compat.append({'id': value, 'minVersion': minVersion, 'maxVersion': maxVersion})
-
- if metadata.has_option('compat', 'gecko'):
- self.compat.append({
- 'id': 'gecko',
- 'minVersion': metadata.get('compat', 'gecko')
- })
def readAndroidMetadata(self):
"""
@@ -269,10 +258,6 @@ class NightlyBuild(object):
manifestPath = os.path.join(baseDir, 'updates.xml')
templateName = 'androidUpdateManifest'
autoescape = True
- elif self.config.type == 'gecko-webext':
- manifestPath = os.path.join(baseDir, 'updates.json')
- templateName = 'geckoUpdateManifest'
- autoescape = False
else:
return
@@ -682,8 +667,7 @@ class NightlyBuild(object):
self.writeChangelog(self.getChanges())
# write update manifest
- if self.config.type != 'gecko':
- self.writeUpdateManifest()
+ self.writeUpdateManifest()
# retire old builds
versions = self.retireBuilds()
« no previous file with comments | « .sitescripts.example ('k') | sitescripts/extensions/bin/updateUpdateManifests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld