Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/layout/footer.tmpl

Issue 29590555: Noissue - Use .container.large-desktop-width for footer .navbar (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Oct. 27, 2017, 9:14 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: includes/layout/footer.tmpl
===================================================================
--- a/includes/layout/footer.tmpl
+++ b/includes/layout/footer.tmpl
@@ -1,29 +1,32 @@
<footer id="site-footer" class="navbar">
- <div class="navbar-wrapper row">
- <div id="site-footer-locales" class="column one-fourth">
- <div id="language-select" class="custom-select">
- <button class="custom-select-selected" aria-expanded="false" aria-haspopup="true">
- {{ config.get("langnames", locale) }}
- </button>
- <ul class="custom-select-options" aria-label="{{ "Select Language" | translate("language-options-label", "Label") }}" role="menu" tabindex="-1">
- {% for available_locale in available_locales %}
- <li class="custom-select-option" role="none">
- {{ page | linkify(available_locale) }}{{ config.get("langnames", available_locale) }}</a>
- </li>
- {% endfor %}
- </ul>
+ <div class="container large-desktop-width">
+ <div class="row">
+ <div id="site-footer-locales" class="column one-fourth">
+ <div id="language-select" class="custom-select">
+ <button class="custom-select-selected" aria-expanded="false" aria-haspopup="true">
+ {{ config.get("langnames", locale) }}
+ </button>
+ <ul class="custom-select-options" aria-label="{{ "Select Language" | translate("language-options-label", "Label") }}" role="menu" tabindex="-1">
+ {% for available_locale in available_locales %}
+ <li class="custom-select-option" role="none">
+ {{ page | linkify(available_locale) }}{{ config.get("langnames", available_locale) }}</a>
+ </li>
+ {% endfor %}
+ </ul>
+ </div>
</div>
- </div>
- <div id="site-footer-nav" class="column three-fourths">
- <nav>
- <ul class="horizontal-list">
- <li><a href="">{{ "Legal" | translate("footer-nav-link-1", "Navigation link") }}</a></li>
- <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" | translate("footer-nav-link-2", "Navigation link") }}</a></li>
- </ul>
- </nav>
- <span class="muted">
- {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" | translate("footer-trademark-notice", "Paragraph") }}
- </span>
- </div>
- </div>
+
+ <div id="site-footer-nav" class="column three-fourths">
+ <nav>
+ <ul class="horizontal-list">
+ <li><a href="">{{ "Legal" | translate("footer-nav-link-1", "Navigation link") }}</a></li>
+ <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" | translate("footer-nav-link-2", "Navigation link") }}</a></li>
+ </ul>
+ </nav>
+ <span class="muted">
+ {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" | translate("footer-trademark-notice", "Paragraph") }}
+ </span>
+ </div>
+ </div> {# .row #}
+ </div> {# .container #}
</footer>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld