Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: popup.js

Issue 29590600: Issue 5951 - Made sure bubble is closed when opening issue reporter in Firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome
Patch Set: Created Oct. 27, 2017, 12:45 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 activateClickHide.timeout = null; 125 activateClickHide.timeout = null;
126 } 126 }
127 document.body.classList.remove("clickhide-active"); 127 document.body.classList.remove("clickhide-active");
128 browser.tabs.sendMessage(tab.id, {type: "composer.content.finished"}); 128 browser.tabs.sendMessage(tab.id, {type: "composer.content.finished"});
129 } 129 }
130 130
131 function reportIssue() 131 function reportIssue()
132 { 132 {
133 browser.tabs.create({ 133 browser.tabs.create({
134 url: browser.runtime.getURL("/issue-reporter.html?" + tab.id) 134 url: browser.runtime.getURL("/issue-reporter.html?" + tab.id)
135 }).then(() =>
136 {
137 window.close();
135 }); 138 });
136 } 139 }
137 140
138 function toggleCollapse(event) 141 function toggleCollapse(event)
139 { 142 {
140 let collapser = event.currentTarget; 143 let collapser = event.currentTarget;
141 let collapsible = document.getElementById(collapser.dataset.collapsible); 144 let collapsible = document.getElementById(collapser.dataset.collapsible);
142 collapsible.classList.toggle("collapsed"); 145 collapsible.classList.toggle("collapsed");
143 togglePref(collapser.dataset.option); 146 togglePref(collapser.dataset.option);
144 } 147 }
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 { 399 {
397 if (event.target.id == "notification-optout") 400 if (event.target.id == "notification-optout")
398 setPref("notifications_ignoredcategories", true); 401 setPref("notifications_ignoredcategories", true);
399 402
400 notificationElement.hidden = true; 403 notificationElement.hidden = true;
401 notification.onClicked(); 404 notification.onClicked();
402 } 405 }
403 }, true); 406 }, true);
404 }); 407 });
405 }); 408 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld