Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29590620: Noissue - Refactor Converter.__init__ and __call__ (Closed)

Created:
Oct. 27, 2017, 5:54 p.m. by Vasily Kuznetsov
Modified:
Nov. 9, 2017, 4:29 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Noissue - Refactor Converter.__init__ and __call__ Repository: https://hg.adblockplus.org/cms/ Base revision: 7348838c1e8f

Patch Set 1 #

Total comments: 25

Patch Set 2 : Address comments on PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -65 lines) Patch
M cms/converters.py View 1 6 chunks +17 lines, -47 lines 0 comments Download
M cms/utils.py View 1 1 chunk +87 lines, -16 lines 0 comments Download
A tests/expected_output/en/includer View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/expected_output/en/sitemap View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/test_site/includes/example.html View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/test_site/pages/includer.md View 1 chunk +5 lines, -0 lines 0 comments Download
A tests/test_site/templates/include-test.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Vasily Kuznetsov
Hi Matze, I'm planning to implement a few changes to make the code of the ...
Oct. 27, 2017, 6:35 p.m. (2017-10-27 18:35:02 UTC) #1
mathias
https://codereview.adblockplus.org/29590620/diff/29590621/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29590620/diff/29590621/cms/converters.py#newcode26 cms/converters.py:26: from cms import utils On 2017/10/27 18:35:01, Vasily Kuznetsov ...
Oct. 30, 2017, 3:37 p.m. (2017-10-30 15:37:01 UTC) #2
Vasily Kuznetsov
Hi Matze, Thanks for your comments, I've addressed them. I'm wondering if we should add ...
Nov. 7, 2017, 5:08 p.m. (2017-11-07 17:08:30 UTC) #3
mathias
Nov. 7, 2017, 7:49 p.m. (2017-11-07 19:49:48 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld