Side by Side Diff: updates.html
Issue 29592569:
Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed)
Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed fifth round of feedback
Created Dec. 5, 2017, 2:36 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« skin/updates.css ('K')
|
« skin/updates/icon-thumbs-up.svg ('k')
|
updates.js » ('j')
|
updates.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <!-- | |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | |
| 4 - Copyright (C) 2006-present eyeo GmbH | |
| 5 - | |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | |
| 7 - it under the terms of the GNU General Public License version 3 as | |
| 8 - published by the Free Software Foundation. | |
| 9 - | |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | |
| 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 13 - GNU General Public License for more details. | |
| 14 - | |
| 15 - You should have received a copy of the GNU General Public License | |
| 16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. | |
| 17 --> | |
| 18 | |
| 19 <html> | |
| 20 <head> | |
| 21 <title class="i18n_updates_status"></title> | |
| 22 <meta charset="utf-8" /> | |
| 23 <meta name="viewport" content="width=device-width, initial-scale=1" /> | |
| 24 <link href="skin/updates.css" rel="stylesheet"/> | |
| 25 <script src="polyfill.js"></script> | |
| 26 <script src="ext/common.js"></script> | |
| 27 <script src="ext/content.js"></script> | |
| 28 <script src="common.js"></script> | |
| 29 <script src="i18n.js"></script> | |
| 30 <script src="updates.js"></script> | |
| 31 </head> | |
| 32 | |
| 33 <body> | |
| 34 | |
| 35 <main> | |
| 36 <div id="container"> | |
| 37 | |
| 38 <header class="column graphic-column"> | |
| 39 <div class="update-graphic-container"> | |
| 40 <div class="update-graphic-content"> | |
| 41 <img src="/skin/abp-logo.svg"/> | |
| 42 <div class="version-details"> | |
| 43 <h2 class="i18n_updates_status"></h2> | |
| 44 </div> | |
| 45 | |
| 46 </div> | |
| 47 </header> | |
| 48 | |
| 49 <section class="column content-column"> | |
| 50 | |
| 51 <div id="content"> | |
| 52 | |
| 53 <header> | |
| 54 <h1 class="i18n_updates_heading"></h1> | |
| 55 <p class="i18n_updates_subheading"></p> | |
| 56 </header> | |
| 57 | |
| 58 <article class="feature-entry"> | |
| 59 <img class="feature-icon" src="/skin/updates/icon-rocket.svg" al t="rocket-icon"/> | |
| 60 <p id="options-page-news" class="i18n_updates_optionsPageNews">< /p> | |
| 61 </article> | |
| 62 | |
| 63 <article class="feature-entry"> | |
| 64 <img class="feature-icon" src="/skin/updates/icon-thumbs-up.svg" alt="thumbs-up-icon"/> | |
|
Thomas Greiner
2018/01/10 12:28:21
Detail: Please remove the alt-text from all three
martin
2018/01/12 11:15:41
Done.
| |
| 65 <p id="block-ads-text" class="i18n_updates_blockAds"></p> | |
| 66 </article> | |
| 67 | |
| 68 <article class="custom-feature-entry"> | |
| 69 <h2 class="i18n_updates_phone"></h2> | |
| 70 | |
| 71 <div class="feature-entry"> | |
| 72 <img class="feature-icon" src="/skin/updates/icon-mobile.svg" alt="thumbs-up-icon"/> | |
| 73 <p id="adblock-browser-text" class="i18n_updates_adblockBrowse r"></p> | |
| 74 </div> | |
| 75 | |
| 76 <div class="store-buttons"> | |
| 77 <a id="adblock_browser_ios_store" class="store-button applesto re-button" target="_blank"> | |
|
Thomas Greiner
2017/12/11 12:11:10
Coding style: "Separate words in ID and class name
martin
2017/12/14 11:25:16
Can I change the `adblock_browser_ios_store` ID? I
Thomas Greiner
2017/12/14 13:36:26
In the JavaScript file you're retrieving the URL f
martin
2017/12/19 12:59:51
Done.
martin
2018/01/12 11:15:41
Done.
| |
| 78 <img src="skin/updates/appstore-bg.svg" alt="apple store but ton"> | |
| 79 </a> | |
| 80 <a id="adblock_browser_android_store" class="store-button goog leplay-button" target="_blank"> | |
| 81 <img src="skin/updates/googleplay-bg.svg" alt="google play s tore button"> | |
| 82 </a> | |
| 83 </div> | |
| 84 | |
| 85 </article> | |
| 86 | |
| 87 </div> | |
| 88 | |
| 89 </section> | |
| 90 | |
| 91 </div> | |
| 92 | |
| 93 </main> | |
| 94 | |
| 95 </body> | |
| 96 | |
| 97 </html> | |
| OLD | NEW |
« skin/updates.css ('K')
|
« skin/updates/icon-thumbs-up.svg ('k')
|
updates.js » ('j')
|
updates.js » ('J')
