locale/en_US/updates.json - Issue 29592569: Issue 5943 - Implement Updates Page for Adblock Plus extension

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: locale/en_US/updates.json

Issue 29592569: Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/

Patch Set: Addressed sixth round of feedback Created Dec. 19, 2017, 12:58 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {

	2 "updates_status" : {

	3 "message": "Update Complete"
	saroyanm 2018/01/05 14:01:47 Deatail: Would be great to do the capitalization i Deatail: Would be great to do the capitalization in CSS, not to adapt the translations saroyanm 2018/01/05 14:09:09 Nevermind: Please make this consistent with the sp Show quoted text On 2018/01/05 14:01:47, saroyanm wrote: > Deatail: Would be great to do the capitalization in CSS, not to adapt the > translations Nevermind: Please make this consistent with the specs lower case "c" -> Update complete martin 2018/01/12 11:15:43 Done. Show quoted text On 2018/01/05 14:01:47, saroyanm wrote: > Deatail: Would be great to do the capitalization in CSS, not to adapt the > translations Done. martin 2018/01/12 11:15:44 Done. Show quoted text On 2018/01/05 14:09:09, saroyanm wrote: > On 2018/01/05 14:01:47, saroyanm wrote: > > Deatail: Would be great to do the capitalization in CSS, not to adapt the > > translations > > Nevermind: Please make this consistent with the specs lower case "c" -> Update > complete Done.
	4 },

	5 "updates_heading": {

	6 "message": "Adblock Plus has been updated!"

	7 },

	8 "updates_subheading": {

	9 "message": "What's new?"

	10 },

	11 "updates_optionsPageNews": {

	12 "message": "Brand new Settings page - revamped and restyled - so it's easier to customize Adblock Plus just like you want it. <a>Check it out for yourself</ a>"
	saroyanm 2018/01/05 14:01:48 The text is different in the Specs -> Brand new Se The text is different in the Specs -> Brand new Settings page - revamped and restyled with more privacy and security options - so it's easier to [customize Adblock Plus just like you want it][1]. See -> https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md martin 2018/01/12 11:15:44 Done. Show quoted text On 2018/01/05 14:01:48, saroyanm wrote: > The text is different in the Specs -> Brand new Settings page - revamped and > restyled with more privacy and security options - so it's easier to [customize > Adblock Plus just like you want it][1]. > > > See -> https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md Done.
	13 },

	14 "updates_blockAds": {

	15 "message": "The Open Source Rebel Alliance created new blocking filters that let you blast hidden ads on websites like Facebook, even if the Empire strikes back."

	16 },

	17 "updates_phone": {

	18 "message": "But wait! What about your phone?"

	19 },

	20 "updates_adblockBrowser": {

	21 "message": "If you like taking control on desktop, you can block ads and imp rove your privacy and security on mobile, too. Get the <a>Adblock Browser App be low</a>."
	saroyanm 2018/01/05 14:01:49 The text is different in specs -> If you are takin The text is different in specs -> If you are taking control on desktop, you can block ads and improve your privacy and security on mobile too. Get the [Adblock Browser App below][1] martin 2018/01/12 11:15:45 Done. Show quoted text On 2018/01/05 14:01:49, saroyanm wrote: > The text is different in specs -> If you are taking control on desktop, you can > block ads and improve your privacy and security on mobile too. Get the [Adblock > Browser App below][1] Done.
	22 }

	23 }
	saroyanm 2018/01/05 14:01:47 Question: Do we have current "New blocking technol Question: Do we have current "New blocking technology! There are now more ways than ever to create new blocking filters that let you blast hidden ads on websites like Facebook, even if the Empire strikes back." text implemented ? See -> https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md#for-g... martin 2018/01/12 11:15:43 I'm not sure how this discussion ended and why we Show quoted text On 2018/01/05 14:01:47, saroyanm wrote: > Question: Do we have current "New blocking technology! There are now more ways > than ever to create new blocking filters that let you blast hidden ads on > websites like Facebook, even if the Empire strikes back." text implemented ? > > See -> > https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md#for-g... I'm not sure how this discussion ended and why we decided to drop these strings from here. Maybe Thomas can pitch in.
OLD	NEW

« no previous file with comments | « no previous file | skin/updates.css » ('j') | skin/updates.css » ('J')