Issue 5943 - Implement Updates Page for Adblock Plus extension

updates.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* globals setLinks, E */

[Thomas Greiner, 2017/11/27 16:15:50]

Detail: You're not using `setLinks()` in this file so no need to list it here.

[martin, 2017/12/05 14:37:32]

I'm now using it to set the link for id="adblock-browser-text". 

+/* globals getDocLink, setLinks, E */
 
 "use strict";
 
 (function()
 {
   function onDOMLoaded()
   {
-    const optionsPageLinkParent = E("options-page-news");
-    const optionsPageLink = optionsPageLinkParent.getElementsByTagName("a")[0];

[Thomas Greiner, 2017/11/27 16:15:51]

Detail: Using `document.querySelector()` you can directly select the element you
want.

e.g.
document.querySelector("#options-page-news > a")

[martin, 2017/12/05 14:37:31]

Fixed.

+    let optionsPageLink = document.querySelector("#options-page-news > a");
     optionsPageLink.addEventListener("click", () =>
     {
       browser.runtime.sendMessage(
         {
           type: "app.open",
           what: "options"
         }
       );
     });
+    getDocLink("adblock_browser_ios_store", (url) =>
+    {
+      E("adblock-browser-ios-store").href = url;
+    });
+    getDocLink("adblock_browser_android_store", (url) =>
+    {
+      E("adblock-browser-android-store").href = url;
+    });
+    getDocLink("adblock_browser_website", (url) =>
+    {
+      setLinks("adblock-browser-text", url);
+    });
   }
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 }());