Delta Between Two Patch Sets: updates.html
Issue 29592569:
Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed)
Base URL: https://hg.adblockplus.org/adblockplusui/
Left Patch Set: Addressed fifth round of feedback
Created Dec. 5, 2017, 2:36 p.m.
Right Patch Set: Addressed seventh round of feedback
Created Jan. 12, 2018, 11:35 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« skin/updates/icon-thumbs-up.svg ('k')
|
updates.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 49 <section class="column content-column"> | 49 <section class="column content-column"> |
| 50 | 50 |
| 51 <div id="content"> | 51 <div id="content"> |
| 52 | 52 |
| 53 <header> | 53 <header> |
| 54 <h1 class="i18n_updates_heading"></h1> | 54 <h1 class="i18n_updates_heading"></h1> |
| 55 <p class="i18n_updates_subheading"></p> | 55 <p class="i18n_updates_subheading"></p> |
| 56 </header> | 56 </header> |
| 57 | 57 |
| 58 <article class="feature-entry"> | 58 <article class="feature-entry"> |
| 59 <img class="feature-icon" src="/skin/updates/icon-rocket.svg" al t="rocket-icon"/> | 59 <img class="feature-icon" src="/skin/updates/icon-rocket.svg"/> |
| 60 <p id="options-page-news" class="i18n_updates_optionsPageNews">< /p> | 60 <p id="options-page-news" class="i18n_updates_optionsPageNews">< /p> |
| 61 </article> | 61 </article> |
| 62 | 62 |
| 63 <article class="feature-entry"> | 63 <article class="feature-entry"> |
| 64 <img class="feature-icon" src="/skin/updates/icon-thumbs-up.svg" alt="thumbs-up-icon"/> | 64 <img class="feature-icon" src="/skin/updates/icon-thumbs-up.svg" /> |
|
Thomas Greiner
2018/01/10 12:28:21
Detail: Please remove the alt-text from all three
martin
2018/01/12 11:15:41
Done.
| |
| 65 <p id="block-ads-text" class="i18n_updates_blockAds"></p> | 65 <p id="block-ads-text" class="i18n_updates_blockAds"></p> |
| 66 </article> | 66 </article> |
| 67 | 67 |
| 68 <article class="custom-feature-entry"> | 68 <article class="custom-feature-entry"> |
| 69 <h2 class="i18n_updates_phone"></h2> | 69 <h2 class="i18n_updates_phone"></h2> |
| 70 | 70 |
| 71 <div class="feature-entry"> | 71 <div class="feature-entry"> |
| 72 <img class="feature-icon" src="/skin/updates/icon-mobile.svg" alt="thumbs-up-icon"/> | 72 <img class="feature-icon" src="/skin/updates/icon-mobile.svg"/ > |
| 73 <p id="adblock-browser-text" class="i18n_updates_adblockBrowse r"></p> | 73 <p id="adblock-browser-text" class="i18n_updates_adblockBrowse r"></p> |
| 74 </div> | 74 </div> |
| 75 | 75 |
| 76 <div class="store-buttons"> | 76 <div class="store-buttons"> |
| 77 <a id="adblock_browser_ios_store" class="store-button applesto re-button" target="_blank"> | 77 <a id="adblock-browser-ios-store" class="store-button applesto re-button" target="_blank"> |
|
Thomas Greiner
2017/12/11 12:11:10
Coding style: "Separate words in ID and class name
martin
2017/12/14 11:25:16
Can I change the `adblock_browser_ios_store` ID? I
Thomas Greiner
2017/12/14 13:36:26
In the JavaScript file you're retrieving the URL f
martin
2017/12/19 12:59:51
Done.
martin
2018/01/12 11:15:41
Done.
| |
| 78 <img src="skin/updates/appstore-bg.svg" alt="apple store but ton"> | 78 <img src="skin/updates/appstore-bg.svg" alt="apple store but ton"> |
| 79 </a> | 79 </a> |
| 80 <a id="adblock_browser_android_store" class="store-button goog leplay-button" target="_blank"> | 80 <a id="adblock-browser-android-store" class="store-button goog leplay-button" target="_blank"> |
| 81 <img src="skin/updates/googleplay-bg.svg" alt="google play s tore button"> | 81 <img src="skin/updates/googleplay-bg.svg" alt="google play s tore button"> |
| 82 </a> | 82 </a> |
| 83 </div> | 83 </div> |
| 84 | 84 |
| 85 </article> | 85 </article> |
| 86 | 86 |
| 87 </div> | 87 </div> |
| 88 | 88 |
| 89 </section> | 89 </section> |
| 90 | 90 |
| 91 </div> | 91 </div> |
| 92 | 92 |
| 93 </main> | 93 </main> |
| 94 | 94 |
| 95 </body> | 95 </body> |
| 96 | 96 |
| 97 </html> | 97 </html> |
| LEFT | RIGHT |
« skin/updates/icon-thumbs-up.svg ('k')
|
updates.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
