Issue 5943 - Implement Updates Page for Adblock Plus extension

updates.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /* globals getDocLink, setLinks, E */
 
 "use strict";
 
 (function()
 {
   function onDOMLoaded()
   {
-    const optionsPageLink = document.querySelector("#options-page-news > a");

[Thomas Greiner, 2018/01/10 12:28:21]

Coding style: "Use const for constant expressions that could as well have been
inlined (e.g. static parameters, imported modules, etc.)."

See https://adblockplus.org/coding-style#javascript-modern

A bit more information on that: By default we always use `let` and we only use
`const` for actual constants and values imported from other modules.

[martin, 2018/01/12 11:15:42]

Done.

+    let optionsPageLink = document.querySelector("#options-page-news > a");
     optionsPageLink.addEventListener("click", () =>
     {
       browser.runtime.sendMessage(
         {
           type: "app.open",
           what: "options"
         }
       );
     });
     getDocLink("adblock_browser_ios_store", (url) =>
     {
-      E("adblock_browser_ios_store").href = url;
+      E("adblock-browser-ios-store").href = url;
     });
     getDocLink("adblock_browser_android_store", (url) =>
     {
-      E("adblock_browser_android_store").href = url;
+      E("adblock-browser-android-store").href = url;
     });
-    setLinks("adblock-browser-text", "https://adblockbrowser.org");

[Thomas Greiner, 2017/12/11 12:11:10]

The second argument is expected to be an array.

See https://hg.adblockplus.org/adblockplusui/file/tip/common.js#l36

[Thomas Greiner, 2017/12/11 12:11:11]

Again, let's not hardcode any links in the extension and instead use
documentation links.

[martin, 2017/12/14 11:25:16]

Couldn't find a doc-link to "https://adblockbrowser.org"... Is there a way to
generate one or am I not looking in the right place?

[Thomas Greiner, 2017/12/14 13:36:26]

The usual process is to update the spec and then inform Ops about implementing
the redirect on the server-side.

There may already be a process already in place to communicate this spec change
to Ops so Winsley may be able to help you with that.

[martin, 2017/12/19 12:59:52]

I `getDocLink`-ed this. It's currently not working, however Winsley knows about
this and will make sure the doc-link is added at some future point.

[Thomas Greiner, 2018/01/10 12:28:22]

Great, thanks.

+    getDocLink("adblock_browser_website", (url) =>
+    {
+      setLinks("adblock-browser-text", url);
+    });
   }
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 }());