Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: updates.js

Issue 29592569: Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/
Left Patch Set: Addressed sixth round of feedback Created Dec. 19, 2017, 12:58 p.m.
Right Patch Set: Addressed seventh round of feedback Created Jan. 12, 2018, 11:35 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « updates.html ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 /* globals getDocLink, setLinks, E */ 18 /* globals getDocLink, setLinks, E */
19 19
20 "use strict"; 20 "use strict";
21 21
22 (function() 22 (function()
23 { 23 {
24 function onDOMLoaded() 24 function onDOMLoaded()
25 { 25 {
26 const optionsPageLink = document.querySelector("#options-page-news > a"); 26 let optionsPageLink = document.querySelector("#options-page-news > a");
27 optionsPageLink.addEventListener("click", () => 27 optionsPageLink.addEventListener("click", () =>
28 { 28 {
29 browser.runtime.sendMessage( 29 browser.runtime.sendMessage(
30 { 30 {
31 type: "app.open", 31 type: "app.open",
32 what: "options" 32 what: "options"
33 } 33 }
34 ); 34 );
35 }); 35 });
36 getDocLink("adblock_browser_ios_store", (url) => 36 getDocLink("adblock_browser_ios_store", (url) =>
37 { 37 {
38 E("adblock-browser-ios-store").href = url; 38 E("adblock-browser-ios-store").href = url;
39 }); 39 });
40 getDocLink("adblock_browser_android_store", (url) => 40 getDocLink("adblock_browser_android_store", (url) =>
41 { 41 {
42 E("adblock-browser-android-store").href = url; 42 E("adblock-browser-android-store").href = url;
43 }); 43 });
44 getDocLink("adblock_browser_website", (url) => 44 getDocLink("adblock_browser_website", (url) =>
45 { 45 {
46 E("adblock-browser-text").href = url; 46 setLinks("adblock-browser-text", url);
Thomas Greiner 2018/01/10 12:28:24 You're not retrieving the `<a>` element here becau
martin 2018/01/12 11:15:46 Done.
47 }); 47 });
48 } 48 }
49 document.addEventListener("DOMContentLoaded", onDOMLoaded, false); 49 document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
50 }()); 50 }());
LEFTRIGHT
« updates.html ('k') | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld