Unified Diff: updates.html
Issue 29592569:
Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed)
Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set:
Created Oct. 30, 2017, 10:37 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« skin/updates.css ('K')
|
« skin/updates-page/icon-thumbs-up.svg ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: updates.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/updates.html |
| @@ -0,0 +1,101 @@ |
| +<!DOCTYPE html> |
| +<!-- |
| + - This file is part of Adblock Plus <https://adblockplus.org/>, |
|
juliandoucette
2017/10/30 15:30:11
This file isn't part of adblockplus.org
martin
2017/11/03 10:02:15
Hmm it looks like this comment block is in every .
juliandoucette
2017/11/03 11:06:05
I was mistaken.
|
| + - Copyright (C) 2006-present eyeo GmbH |
| + - |
| + - Adblock Plus is free software: you can redistribute it and/or modify |
| + - it under the terms of the GNU General Public License version 3 as |
| + - published by the Free Software Foundation. |
| + - |
| + - Adblock Plus is distributed in the hope that it will be useful, |
| + - but WITHOUT ANY WARRANTY; without even the implied warranty of |
| + - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| + - GNU General Public License for more details. |
| + - |
| + - You should have received a copy of the GNU General Public License |
| + - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| +--> |
| + |
| +<html> |
| +<head> |
| + <title class="i18n_firstRun_title"></title> |
| + <meta charset="utf-8" /> |
| + <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| + <link type="text/css" href="skin/common.css" rel="stylesheet" /> |
| + <link type="text/css" href="skin/defaults.css" rel="stylesheet" /> |
|
juliandoucette
2017/10/30 15:30:11
You didn't upload default.css with this review or
martin
2017/11/03 10:02:14
I actually removed the default.css dependency as I
|
| + <link type="text/css" href="skin/updates.css" rel="stylesheet"/> |
| + <script type="text/javascript" src="polyfill.js"></script> |
| + <script type="text/javascript" src="ext/common.js"></script> |
| + <script type="text/javascript" src="ext/content.js"></script> |
| + <script type="text/javascript" src="common.js"></script> |
| + <script type="text/javascript" src="i18n.js"></script> |
| +</head> |
| + |
| +<body> |
| + |
| + <main> |
|
juliandoucette
2017/10/30 15:30:11
<main> has no heading. I suggest that you use the
martin
2017/11/03 10:02:14
First <section> is now a <header> element.
|
| + |
| + <div class="container content full-width-container"> |
|
juliandoucette
2017/10/30 15:30:11
.container and .full-width-container are contradic
martin
2017/11/03 10:02:14
Ended up simply creating an id called "container".
|
| + |
| + <div class="row"> |
| + |
| + <section class="column graphic-column"> |
| + <div class="update-graphic-container"> |
| + <div class="update-graphic-content"> |
| + <img src="/skin/updates-page/abp-logo.svg" alt="adblock-plus-logo"/> |
| + <div class="version-details"> |
| + <h2>Update Complete</h2> |
| + <span>v1.13.4</span> |
| + </div> |
| + |
| + </div> |
| + </section> |
| + |
| + <section class="column content-column"> |
| + |
| + <div class="content-column-entries"> |
| + |
| + <hgroup> |
| + <h1>Adblock Plus has been updated!</h1> |
| + <h2>What's new?</h2> |
|
juliandoucette
2017/10/30 15:30:11
NIT: It's recommended to use header instead of hgr
martin
2017/11/03 10:02:13
Oh I've done this so many times, didn't realise it
|
| + </hgroup> |
| + |
| + <div class="feature-entry"> |
|
juliandoucette
2017/10/30 15:30:10
Suggest: I think these could be <article>s
martin
2017/11/03 10:02:13
feature-entries are now <article>s
|
| + <img class="feature-icon" src="/skin/updates-page/icon-rocket.svg" alt="rocket-icon"/> |
| + <p>All new Options page - revamped and restyled - so it’s easier to customize Adblock Plus just like you want it. <a href="#">Check it out for yourself</a>.</p> |
|
juliandoucette
2017/10/30 15:30:10
NIT: I think the first text could be an inline hea
martin
2017/11/03 10:02:14
I totally get what you mean, however I don't want
juliandoucette
2017/11/03 11:06:05
Ack. I think that these should only be <article>s
|
| + </div> |
| + |
| + <div class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates-page/icon-thumbs-up.svg" alt="thumbs-up-icon"/> |
| + <p>Block ads on Facebook again! New blocking tech allows for fast fixes in case <strike>the Empire</strike> Facebook strikes back.</p> |
| + </div> |
| + |
| + <div class="custom-feature-entry"> |
| + <h2>But what about your phone?</h2> |
| + <div class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates-page/icon-mobile.svg" alt="thumbs-up-icon"/> |
|
juliandoucette
2017/10/30 15:30:10
NIT: The phone alignment looks weird. Maybe align
martin
2017/11/03 10:02:13
It doesn't look that bad to me TBH. Every other ic
juliandoucette
2017/11/03 11:06:06
Acknowledged.
Looks fine to me on second glance :
|
| + <p>If you like taking control on desktop, you can block ads and improve your privacy and security on mobile, too. Get the Adblock Browser App below.</p> |
| + </div> |
| + <div class="store-buttons"> |
| + <a href="" class="store-button applestore-button"> |
| + <img src="skin/updates-page/appstore-bg.svg" alt="apple store button"> |
| + </a> |
| + <a href="" class="store-button googleplay-button"> |
| + <img src="skin/updates-page/googleplay-bg.svg" alt="google play store button"> |
| + </a> |
| + </div> |
| + </div> |
| + |
| + </div> |
| + |
| + </section> |
| + |
| + </div> |
| + |
| + </div> |
| + |
| + </main> |
| + |
| +</body> |
| + |
| +</html> |
« skin/updates.css ('K')
|
« skin/updates-page/icon-thumbs-up.svg ('k')
|
no next file »
|
no next file with comments »
