Unified Diff: updates.html
Issue 29592569:
Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed)
Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed initial round of feedback
Created Nov. 3, 2017, 10:01 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« skin/updates-page/googleplay-bg.svg ('K')
|
« skin/updates-page/icon-thumbs-up.svg ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: updates.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/updates.html |
| @@ -0,0 +1,95 @@ |
| +<!-- |
| + - This file is part of Adblock Plus <https://adblockplus.org/>, |
| + - Copyright (C) 2006-present eyeo GmbH |
| + - |
| + - Adblock Plus is free software: you can redistribute it and/or modify |
| + - it under the terms of the GNU General Public License version 3 as |
| + - published by the Free Software Foundation. |
| + - |
| + - Adblock Plus is distributed in the hope that it will be useful, |
| + - but WITHOUT ANY WARRANTY; without even the implied warranty of |
| + - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| + - GNU General Public License for more details. |
| + - |
| + - You should have received a copy of the GNU General Public License |
| + - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| + --> |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| + <title class="i18n_firstRun_title"></title> |
|
Thomas Greiner
2017/11/03 17:40:01
Coding style: "Indentation: Two spaces per logic l
Thomas Greiner
2017/11/03 17:40:02
This class name refers to the wrong message ID.
martin
2017/11/06 16:05:46
Done.
martin
2017/11/06 16:05:46
Done.
|
| + <meta charset="utf-8" /> |
| + <meta name="viewport" content="width=device-width, initial-scale=1" /> |
|
Thomas Greiner
2017/11/03 17:40:02
I'm fine with adding this to have a more pleasant
martin
2017/11/06 16:05:50
This page would never be viewed from a mobile devi
Thomas Greiner
2017/11/14 12:25:39
The spec doesn't mention that this should only app
|
| + <link type="text/css" href="skin/common.css" rel="stylesheet" /> |
|
Thomas Greiner
2017/11/03 17:40:02
Detail: None of the styles included in common.css
martin
2017/11/06 16:05:46
Done.
|
| + <link type="text/css" href="skin/updates.css" rel="stylesheet"/> |
| + <script type="text/javascript" src="polyfill.js"></script> |
|
Thomas Greiner
2017/11/03 17:40:02
Detail: The "type" attribute has been made optiona
martin
2017/11/06 16:05:49
Done.
|
| + <script type="text/javascript" src="ext/common.js"></script> |
| + <script type="text/javascript" src="ext/content.js"></script> |
| + <script type="text/javascript" src="common.js"></script> |
| + <script type="text/javascript" src="i18n.js"></script> |
| +</head> |
| + |
| +<body> |
| + |
| + <main> |
| + <div id="container"> |
| + |
| + <header class="column graphic-column"> |
| + <div class="update-graphic-container"> |
| + <div class="update-graphic-content"> |
| + <img src="/skin/updates-page/abp-logo.svg" alt="adblock-plus-logo"/> |
|
Thomas Greiner
2017/11/03 17:40:02
Detail: Texts in "alt" attributes are just as visi
martin
2017/11/06 16:05:49
Done.
|
| + <div class="version-details"> |
| + <h2>Update Complete</h2> |
|
Thomas Greiner
2017/11/03 17:40:02
We mentioned it in today's meeting but just for co
Thomas Greiner
2017/11/03 17:40:03
Detail: I noticed that if this text is longer (i.e
martin
2017/11/06 16:05:49
Done.
martin
2017/11/06 16:05:49
Done.
|
| + <span>v1.13.4</span> |
|
Thomas Greiner
2017/11/03 17:40:01
Detail: The version number may end up being differ
martin
2017/11/06 16:05:46
I removed the version number <span> to not delay i
|
| + </div> |
| + |
| + </div> |
| + </header> |
| + |
| + <section class="column content-column"> |
| + |
| + <div id="content"> |
| + |
| + <header> |
| + <h1>Adblock Plus has been updated!</h1> |
| + <p>What's new?</p> |
| + </header> |
| + |
| + <article class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates-page/icon-rocket.svg" alt="rocket-icon"/> |
| + <p>All new Options page - revamped and restyled - so it’s easier to customize Adblock Plus just like you want it. <a href="#">Check it out for yourself</a>.</p> |
|
Thomas Greiner
2017/11/03 17:40:01
Detail: We try to normalize strings, for instance
Thomas Greiner
2017/11/03 17:40:02
This link and the app store buttons below are miss
martin
2017/11/06 16:05:46
Done.
|
| + </article> |
| + |
| + <article class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates-page/icon-thumbs-up.svg" alt="thumbs-up-icon"/> |
| + <p>Block ads on Facebook again! New blocking tech allows for fast fixes in case <strike>the Empire</strike> Facebook strikes back.</p> |
|
Thomas Greiner
2017/11/03 17:40:02
The `<strike>` element has been deprecated in HTML
martin
2017/11/06 16:05:46
Done.
|
| + </article> |
| + |
| + <article class="custom-feature-entry"> |
| + <h2>But what about your phone?</h2> |
| + <div class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates-page/icon-mobile.svg" alt="thumbs-up-icon"/> |
| + <p>If you like taking control on desktop, you can block ads and improve your privacy and security on mobile, too. Get the Adblock Browser App below.</p> |
| + </div> |
| + <div class="store-buttons"> |
| + <a href="" class="store-button applestore-button"> |
| + <img src="skin/updates-page/appstore-bg.svg" alt="apple store button"> |
| + </a> |
| + <a href="" class="store-button googleplay-button"> |
| + <img src="skin/updates-page/googleplay-bg.svg" alt="google play store button"> |
|
Thomas Greiner
2017/11/03 17:40:01
Are we allowed to use those images? Because accord
Thomas Greiner
2017/11/03 17:40:02
These images contain text which we means that we c
martin
2017/11/06 16:05:49
We could potentially do that, but it'll slow us do
martin
2017/11/06 16:05:50
Apple store button is in accordance with their gui
Thomas Greiner
2017/11/14 12:25:40
Great, thanks!
|
| + </a> |
| + </div> |
| + </article> |
| + |
| + </div> |
| + |
| + </section> |
| + |
| + </div> |
| + |
| + </main> |
| + |
| + </body> |
| + |
| + </html> |
| + |
« skin/updates-page/googleplay-bg.svg ('K')
|
« skin/updates-page/icon-thumbs-up.svg ('k')
|
no next file »
|
no next file with comments »
