Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: issue-reporter.js

Issue 29592569: Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed second round of feedback Created Nov. 6, 2017, 4:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « desktop-options.html ('k') | locale/en_US/desktop-options.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: issue-reporter.js
===================================================================
--- a/issue-reporter.js
+++ b/issue-reporter.js
@@ -398,29 +398,22 @@
let component = uuid[i].toString(16);
while (component.length < 4)
component = "0" + component;
uuidString += component;
if (i >= 1 && i <= 4)
uuidString += "-";
}
- // Passing a sequence to URLSearchParams() constructor only works starting
- // with Firefox 53, add values "manually" for now.
- let params = new URLSearchParams();
- for (let [param, value] of [
- ["version", 1],
- ["guid", uuidString],
- ["lang", reportData.getElementsByTagName("adblock-plus")[0]
- .getAttribute("locale")]
- ])
- {
- params.append(param, value);
- }
-
+ let params = new URLSearchParams({
+ version: 1,
+ guid: uuidString,
+ lang: reportData.getElementsByTagName("adblock-plus")[0]
+ .getAttribute("locale")
+ });
let url = "https://reports.adblockplus.org/submitReport?" + params;
let reportSent = event =>
{
let success = false;
let errorMessage = browser.i18n.getMessage(
"filters_subscription_lastDownload_connectionError"
);
« no previous file with comments | « desktop-options.html ('k') | locale/en_US/desktop-options.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld