Unified Diff: updates.html
Issue 29592569:
Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed)
Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed third round of feedback
Created Nov. 20, 2017, 11:44 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« skin/updates/googleplay-bg.svg ('K')
|
« skin/updates/icon-thumbs-up.svg ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: updates.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/updates.html |
| @@ -0,0 +1,94 @@ |
| +<!DOCTYPE html> |
| +<!-- |
| + - This file is part of Adblock Plus <https://adblockplus.org/>, |
| + - Copyright (C) 2006-present eyeo GmbH |
| + - |
| + - Adblock Plus is free software: you can redistribute it and/or modify |
| + - it under the terms of the GNU General Public License version 3 as |
| + - published by the Free Software Foundation. |
| + - |
| + - Adblock Plus is distributed in the hope that it will be useful, |
| + - but WITHOUT ANY WARRANTY; without even the implied warranty of |
| + - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| + - GNU General Public License for more details. |
| + - |
| + - You should have received a copy of the GNU General Public License |
| + - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| + --> |
| + |
| +<html> |
| + <head> |
| + <title class="i18n_updates_status"></title> |
| + <meta charset="utf-8" /> |
| + <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| + <link href="skin/updates.css" rel="stylesheet"/> |
| + <script src="polyfill.js"></script> |
| + <script src="ext/common.js"></script> |
| + <script src="ext/content.js"></script> |
| + <script src="common.js"></script> |
| + <script src="i18n.js"></script> |
| + <script src="updates.js"></script> |
|
Thomas Greiner
2017/11/20 17:06:07
This file is not included in the review so please
martin
2017/11/26 17:08:40
Done.
|
| + </head> |
| + |
| + <body> |
| + |
| + <main> |
| + <div id="container"> |
| + |
| + <header class="column graphic-column"> |
| + <div class="update-graphic-container"> |
| + <div class="update-graphic-content"> |
| + <img src="/skin/abp-logo.svg"/> |
| + <div class="version-details"> |
| + <h2 class="i18n_updates_status"></h2> |
| + </div> |
| + |
| + </div> |
| + </header> |
| + |
| + <section class="column content-column"> |
| + |
| + <div id="content"> |
| + |
| + <header> |
| + <h1 class="i18n_updates_heading"></h1> |
| + <p class="i18n_updates_subheading"></p> |
| + </header> |
| + |
| + <article class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates/icon-rocket.svg" alt="rocket-icon"/> |
| + <p id="optionsPageNews" class="i18n_updates_optionsPageNews"></p> |
|
Thomas Greiner
2017/11/20 17:06:07
Coding style: "Separate words in ID and class name
martin
2017/11/26 17:08:40
Done.
|
| + </article> |
| + |
| + <article class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates/icon-thumbs-up.svg" alt="thumbs-up-icon"/> |
| + <p id="block-ads-text" class="i18n_updates_blockAds"></p> |
| + </article> |
| + |
| + <article class="custom-feature-entry"> |
| + <h2 class="i18n_updates_phone"></h2> |
| + <div class="feature-entry"> |
| + <img class="feature-icon" src="/skin/updates/icon-mobile.svg" alt="thumbs-up-icon"/> |
| + <p class="i18n_updates_adblockBrowser"></p> |
| + </div> |
| + <div class="store-buttons"> |
| + <a href="https://eyeo.to/adblockbrowser/ios/update-page" class="store-button applestore-button"> |
|
Thomas Greiner
2017/11/20 17:06:07
We use documentation links (see https://bitbucket.
martin
2017/11/26 17:08:39
I'm sort of confused as to how to use this. The `g
Thomas Greiner
2017/11/27 16:15:47
No, the `getDocLink()` function gives you the URL
martin
2017/12/05 14:37:29
Aaaaah! I get it now. Thanks for the explanation.
|
| + <img src="skin/updates/appstore-bg.svg" alt="apple store button"> |
| + </a> |
| + <a href="https://eyeo.to/adblockbrowser/android/update-page" class="store-button googleplay-button"> |
| + <img src="skin/updates/googleplay-bg.svg" alt="google play store button"> |
| + </a> |
| + </div> |
| + </article> |
| + |
| + </div> |
| + |
| + </section> |
| + |
| + </div> |
| + |
| + </main> |
| + |
| + </body> |
| + |
| + </html> |
« skin/updates/googleplay-bg.svg ('K')
|
« skin/updates/icon-thumbs-up.svg ('k')
|
no next file »
|
no next file with comments »
