metadata.chrome - Issue 29592604: Issue 5957 - Get the unit tests passing again

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.chrome

Issue 29592604: Issue 5957 - Get the unit tests passing again (Closed)

Left Patch Set: Created Oct. 30, 2017, 2:53 p.m.

Right Patch Set: lib/adblockplus.js isn't required for the tests anymore Created Oct. 30, 2017, 3:17 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 1.13.4	3 version = 1.13.4

4 author = eyeo GmbH	4 author = eyeo GmbH

5 permissions = tabs	5 permissions = tabs

6 <all_urls>	6 <all_urls>

7 contextMenus	7 contextMenus

8 webRequest	8 webRequest

9 webRequestBlocking	9 webRequestBlocking

10 webNavigation	10 webNavigation

11 storage	11 storage

12 unlimitedStorage	12 unlimitedStorage

13 notifications	13 notifications

14 backgroundScripts = polyfill.js	14 backgroundScripts = polyfill.js

15 ext/common.js	15 ext/common.js

16 ext/background.js	16 ext/background.js

17 lib/compat.js	17 lib/compat.js

18 lib/publicSuffixList.js	18 lib/publicSuffixList.js

19 lib/adblockplus.js	19 lib/adblockplus.js

20 testScripts = ../polyfill.js	20 testScripts = ../polyfill.js

21 ../ext/common.js	21 ../ext/common.js

22 ../ext/background.js	22 ../ext/background.js

23 ../lib/compat.js	23 ../lib/compat.js

24 ../lib/adblockplus.js

25 ../lib/publicSuffixList.js	24 ../lib/publicSuffixList.js

26 tests.js	25 tests.js

27 options = options.html	26 options = options.html

28 devtools = devtools.html	27 devtools = devtools.html

29 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-20.png icons/abp-32. png icons/abp-38.png icons/abp-40.png popup.html	28 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-20.png icons/abp-32. png icons/abp-38.png icons/abp-40.png popup.html

30 icons = icons/abp-16.png icons/abp-32.png icons/detailed/abp-48.png	29 icons = icons/abp-16.png icons/abp-32.png icons/detailed/abp-48.png

31 icons/detailed/abp-64.png icons/detailed/abp-128.png	30 icons/detailed/abp-64.png icons/detailed/abp-128.png

32 managedStorageSchema = managed-storage-schema.json	31 managedStorageSchema = managed-storage-schema.json

33	32

34 [compat]	33 [compat]

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 qunit/tests.js =	91 qunit/tests.js =

93 qunit/common.js	92 qunit/common.js

94 qunit/tests/prefs.js	93 qunit/tests/prefs.js

95 qunit/tests/url.js	94 qunit/tests/url.js

96 qunit/tests/cssEscaping.js	95 qunit/tests/cssEscaping.js

97	96

98 [import_locales]	97 [import_locales]

99 adblockplusui/locale//firstRun.json =	98 adblockplusui/locale//firstRun.json =

100 adblockplusui/locale//antiadblockInit.json =	99 adblockplusui/locale//antiadblockInit.json =

101 adblockplusui/locale//issue-reporter.json =	100 adblockplusui/locale//issue-reporter.json =

LEFT	RIGHT