pages/legal.md - Issue 29593561: Issue 5961 - Add Imprint page to help.eyeo.com

Side by Side Diff: pages/legal.md

Issue 29593561: Issue 5961 - Add Imprint page to help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Patch Set: Created Oct. 31, 2017, 8:55 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 title=Imprint

	2
	juliandoucette 2017/10/31 12:34:10 NIT: No description? NIT: No description? ire 2017/11/01 09:18:13 There isn't one in the spec Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > NIT: No description? There isn't one in the spec juliandoucette 2017/11/01 13:09:46 NIT/Suggest: Ask for one. (Can be addressed separ Show quoted text On 2017/11/01 09:18:13, ire wrote: > On 2017/10/31 12:34:10, juliandoucette wrote: > > NIT: No description? > > There isn't one in the spec NIT/Suggest: Ask for one. (Can be addressed separately.) ire 2017/11/02 09:20:54 https://issues.adblockplus.org/ticket/5968 Show quoted text On 2017/11/01 13:09:46, juliandoucette wrote: > On 2017/11/01 09:18:13, ire wrote: > > On 2017/10/31 12:34:10, juliandoucette wrote: > > > NIT: No description? > > > > There isn't one in the spec > > NIT/Suggest: Ask for one. > > (Can be addressed separately.) https://issues.adblockplus.org/ticket/5968
	3 <style>

	4 hr { margin: 2em 0; }

	5

	6 @media (min-width: 576px)

	7 {

	8 hr { margin: 3em 0; }

	9 }

	10 </style>

	11

	12 <div class="column two-thirds" markdown="1">
	juliandoucette 2017/10/31 12:34:10 Suggest: Organization schema (or similar, includin Suggest: Organization schema (or similar, including sub-schemas e.g. address, contact info, people/roles) ire 2017/11/01 09:18:12 Good idea. Done. Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > Suggest: Organization schema (or similar, including sub-schemas e.g. address, > contact info, people/roles) Good idea. Done.
	13

	14 # {{ imprint[heading] Imprint }}

	15

	16 ---
	juliandoucette 2017/10/31 12:34:10 NIT: I think these lines are presentational (and h NIT: I think these lines are presentational (and hr is supposed to be semantic in HTML5?) ire 2017/11/01 09:18:12 I don't think they are purely presentational. They Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > NIT: I think these lines are presentational (and hr is supposed to be semantic > in HTML5?) I don't think they are purely presentational. They are separating different sections of the content. juliandoucette 2017/11/01 13:09:46 Ack. NIT: It looks like a heading followed by thre Show quoted text On 2017/11/01 09:18:12, ire wrote: > On 2017/10/31 12:34:10, juliandoucette wrote: > > NIT: I think these lines are presentational (and hr is supposed to be semantic > > in HTML5?) > > I don't think they are purely presentational. They are separating different > sections of the content. Ack. NIT: It looks like a heading followed by three sections with border-top to me. ire 2017/11/02 09:20:54 But three sections means there are different secti Show quoted text On 2017/11/01 13:09:46, juliandoucette wrote: > On 2017/11/01 09:18:12, ire wrote: > > On 2017/10/31 12:34:10, juliandoucette wrote: > > > NIT: I think these lines are presentational (and hr is supposed to be > semantic > > > in HTML5?) > > > > I don't think they are purely presentational. They are separating different > > sections of the content. > > Ack. NIT: It looks like a heading followed by three sections with border-top to > me. But three sections means there are different sections of content :P Haha we may have to agree to disagree on this one
	17

	18 ## {{ eyeo-gmbh[heading] eyeo GmbH }}

	19

	20 {{ eyeo-address-street[address] Lichtstraße 25 }}<br>
	ire 2017/10/31 08:57:33 I separated this into different lines/translations I separated this into different lines/translations because: 1. I wanted to keep this a markdown file 2. I couldn't find a way to separate the line (<br>) using this translation format. juliandoucette 2017/10/31 12:34:10 1. Why? I don't expect this page to change or be e Show quoted text On 2017/10/31 08:57:33, ire wrote: > I separated this into different lines/translations because: > > 1. I wanted to keep this a markdown file > 2. I couldn't find a way to separate the line (<br>) using this translation > format. 1. Why? I don't expect this page to change or be edited often. 2. Our address doesn't have to be translated ire 2017/11/01 09:18:13 Actually, since I am taking your suggestions to do Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > On 2017/10/31 08:57:33, ire wrote: > > I separated this into different lines/translations because: > > > > 1. I wanted to keep this a markdown file > > 2. I couldn't find a way to separate the line (<br>) using this translation > > format. > > 1. Why? I don't expect this page to change or be edited often. > 2. Our address doesn't have to be translated Actually, since I am taking your suggestions to do the Organization schema, I might as well change this whole page to HTML. Also, I'm realising I probably over-translated here (e.g. translated phone numbers). I'm going to remove translations for more things. ire 2017/11/01 09:18:13 1. Maybe not, but I figured that this is the sort Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > On 2017/10/31 08:57:33, ire wrote: > > I separated this into different lines/translations because: > > > > 1. I wanted to keep this a markdown file > > 2. I couldn't find a way to separate the line (<br>) using this translation > > format. > > 1. Why? I don't expect this page to change or be edited often. > 2. Our address doesn't have to be translated 1. Maybe not, but I figured that this is the sort of file we would want content editors to be able to change easily? 2. Probably not, but it's simpler to have everything in the translation format. I think we discussed and decided to translate everything on our end, and the decision can be made elsewhere if the text will actually be translated.
	21 {{ eyeo-address-city[address] 50825 Cologne }}<br>

	22 {{ eyeo-address-country[address] Germany }}
	juliandoucette 2017/10/31 12:34:10 Suggest: <address> Suggest: <address> ire 2017/11/01 09:18:13 Done. Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > Suggest: <address> Done.
	23

	24 ---

	25

	26 {{ imprint-contact-forum For suppoprt please goto: [Adblock Plus Forum](https:/ /adblockplus.org/forum/) }}<br>
	juliandoucette 2017/10/31 12:34:10 Suggest: description list Suggest: description list ire 2017/11/01 09:18:13 Done. Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > Suggest: description list Done.
	27 {{ imprint-contact-email Email: [support@adblockplus.org](mailto:support@adblock plus.org) }}<br>

	28 {{ imprint-contact-phone Phone: +49 (0)221 / 65028 598 }}<br>

	29 {{ imprint-contact-fax Fax: +49 (0)221 / 65028 599 }}<br>

	30 {{ imprint-contact-vat Ust-IdNr: DE279292414 }}<br>

	31 {{ imprint-contact-district District Court: Köln HRB 73508 }}

	32

	33 ---

	34

	35 ## {{ imprint-directors[heading] Managing Directors }}

	36

	37 {{ till-faida[name] Till Faida }}<br>
	juliandoucette 2017/10/31 12:34:10 NIT: These names don't have to be translated Sugge NIT: These names don't have to be translated Suggest: Unstyled, unordered, list ire 2017/11/01 09:18:13 Now I'm not sure about my previous comment about a Show quoted text On 2017/10/31 12:34:10, juliandoucette wrote: > NIT: These names don't have to be translated Now I'm not sure about my previous comment about always translating everything. Although I still think it cleaner. Show quoted text > Suggest: Unstyled, unordered, list Done.
	38 {{ felix-dahlke[name] Felix Dahlke }}<br>

	39 {{ steffen-kiedel[name] Steffen Kiedel }}

	40

	41 </div>

OLD	NEW

« no previous file with comments | « includes/layout/footer.tmpl ('k') | no next file » | no next file with comments »