Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/legal.html

Issue 29593561: Issue 5961 - Add Imprint page to help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Organization schema, convert to html, remove unneeded translations Created Nov. 1, 2017, 9:17 a.m.
Right Patch Set: Update <hr> spacing, add comments, update Till itemprop Created Nov. 2, 2017, 9:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/layout/footer.tmpl ('k') | static/scss/base/_utilities.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Imprint 1 title=Imprint
2 2
3 <style> 3 <style>
4 hr { margin: 2em 0; } 4 hr { margin: 2em 0; }
5 5
6 @media (min-width: 576px) 6 /* Remove margin-top on <h2> directly after <hr> */
7 { 7 .content hr + h2 { margin-top: 0; }
8 hr { margin: 3em 0; }
juliandoucette 2017/11/01 13:09:46 NIT/Suggest: This is too much space?
ire 2017/11/02 09:20:54 Done.
9 }
10 8
11 .unstyled dt, 9 .unstyled dt,
12 .unstyled dd 10 .unstyled dd
13 { 11 {
14 display: inline; 12 display: inline;
15 } 13 }
16 14
15 /* Force a new line after each <dd> */
17 .unstyled dd:after 16 .unstyled dd:after
juliandoucette 2017/11/01 13:09:46 NIT/Suggest: Explain this clever solution via comm
ire 2017/11/02 09:20:54 Done :)
18 { 17 {
19 content: ""; 18 content: "";
20 display: block; 19 display: block;
21 } 20 }
22 </style> 21 </style>
23 22
24 <div class="column two-thirds" itemscope itemtype="http://schema.org/Organizatio n"> 23 <div class="column two-thirds" itemscope itemtype="http://schema.org/Organizatio n">
25 24
26 <h1>{{ imprint[heading] Imprint }}</h1> 25 <h1>{{ imprint[heading] Imprint }}</h1>
27 26
(...skipping 27 matching lines...) Expand all
55 54
56 <dt>{{ imprint-contact-district-title District Court: }}</dt> 55 <dt>{{ imprint-contact-district-title District Court: }}</dt>
57 <dd>Köln HRB 73508</dd> 56 <dd>Köln HRB 73508</dd>
58 </dl> 57 </dl>
59 58
60 <hr> 59 <hr>
61 60
62 <h2>{{ imprint-directors[heading] Managing Directors }}</h2> 61 <h2>{{ imprint-directors[heading] Managing Directors }}</h2>
63 62
64 <ul class="unstyled"> 63 <ul class="unstyled">
65 <li itemprop="founder" itemscope itemtype="http://schema.org/Person"> 64 <li itemprop="founder employee" itemscope itemtype="http://schema.org/Person ">
66 <span itemprop="name">Till Faida</span> 65 <span itemprop="name">Till Faida</span>
67 </li> 66 </li>
68 <li itemprop="employee" itemscope itemtype="http://schema.org/Person"> 67 <li itemprop="employee" itemscope itemtype="http://schema.org/Person">
ire 2017/11/01 09:19:11 I'm not sure about this, but I couldn't find any o
juliandoucette 2017/11/01 13:09:46 I'm not sure either. My intuition says "founders"
ire 2017/11/02 09:20:54 Don't know why I didn't look this up before, but a
69 <span itemprop="name">Felix Dahlke</span> 68 <span itemprop="name">Felix Dahlke</span>
70 </li> 69 </li>
71 <li itemprop="employee" itemscope itemtype="http://schema.org/Person"> 70 <li itemprop="employee" itemscope itemtype="http://schema.org/Person">
72 <span itemprop="name">Steffen Kiedel</span> 71 <span itemprop="name">Steffen Kiedel</span>
73 </li> 72 </li>
74 </ul> 73 </ul>
75 74
76 </div> 75 </div>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld