Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: compiled/ElemHideEmulation.cpp

Issue 29594607: Issue 5143 - Convert ElemHideEmulation to C++ (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 1, 2017, 2:42 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH
4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation.
8 *
9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
13 *
14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18 #include "ElemHide.h"
19 #include "ElemHideEmulation.h"
20
21 ElemHideEmulation* ElemHideEmulation::mInstance = new ElemHideEmulation();
22
23 void ElemHideEmulation::Add(ElemHideBase& filter)
24 {
25 mFilters[filter.GetText()] = ElemHideBasePtr(&filter);
26 }
27
28 void ElemHideEmulation::Remove(ElemHideBase& filter)
29 {
30 mFilters.erase(filter.GetText());
31 }
32
33 void ElemHideEmulation::Clear()
34 {
35 mFilters.clear();
36 }
37
38 _ElemHideEmulation_FilterList* ElemHideEmulation::GetRulesForDomain(DependentStr ing& domain)
39 {
40 auto result = new _ElemHideEmulation_FilterList;
sergei 2017/11/16 09:58:06 I would prefer to have the type of `result` intrus
hub 2017/11/20 19:16:00 Done.
41 for (auto filter: mFilters)
42 {
43 DependentString docDomain(domain);
hub 2017/11/02 04:11:13 IsActiveOnDomain() will modify the DependentString
sergei 2017/11/16 09:58:06 agree.
44 if (!filter.is_deleted() &&
hub 2017/11/02 04:11:13 IMHO we should change StringMap<> iterator so that
sergei 2017/11/16 09:58:06 agree
45 filter.second->IsActiveOnDomain(docDomain, u""_str) &&
46 !ElemHide::GetInstance()->GetException(*filter.second, domain))
47 result->push_back(filter.second);
48 }
49
50 return result;
51 }
OLDNEW

Powered by Google App Engine
This is Rietveld