Issue 5143 - Convert ElemHideEmulation to C++

test/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 92 matching lines @@
   function testSelectorMatches(description, filters, domain, expectedMatches)
   {
     for (let text of filters)
     {
       let filter = Filter.fromText(text);
       if (filter instanceof ElemHideEmulationFilter)
         ElemHideEmulation.add(filter);
       else
         ElemHide.add(filter);
     }
-    let matches = ElemHideEmulation.getRulesForDomain(domain)
-        .map(filter => filter.text);
+
+    let rules = ElemHideEmulation.getRulesForDomain(domain);
+    let matches = [];
+    for (let i = 0; i < rules.filterCount; i++)
+      matches.push(rules.filterAt(i).text);
     test.deepEqual(matches.sort(), expectedMatches.sort(), description);
 
     ElemHideEmulation.clear();
     ElemHide.clear();
   }
 
   testSelectorMatches(
     "Ignore generic filters",
     [
       "##[-abp-properties='foo']", "example.com##[-abp-properties='foo']",
@@ skipping 39 matching lines @@
     ["other.example.com##[-abp-properties='foo']"]
   );
 
   test.done();
 };
 
 exports.testElemHideEmulationFiltersContainer = function(test)
 {
   function compareRules(description, domain, expectedMatches)
   {
-    let result = ElemHideEmulation.getRulesForDomain(domain)
-        .map(filter => filter.text);
+    let rules = ElemHideEmulation.getRulesForDomain(domain);

[sergei, 2017/11/16 09:58:07]

What about returning a generator object from ElemHideEmulation.getRulesForDomain
(similar to
https://github.com/adblockplus/adblockpluscore/blob/emscripten/lib/filterStor...

BTW, one should call `delete` on the result of `rules.filterAt(i)` and on
`rules`.

[hub, 2017/11/20 19:16:01]

delete on the result of `rules.filterAt(i)` is an error with the current
implementation. I'll change filterAt() to match FilterStorage.

I am not convinced on having that iterator / generator since it involve writing
JS code.

+    let result = [];
+    for (let i = 0; i < rules.filterCount; i++)
+      result.push(rules.filterAt(i).text);
     expectedMatches = expectedMatches.map(filter => filter.text);
     test.deepEqual(result.sort(), expectedMatches.sort(), description);
   }
 
   let domainFilter = Filter.fromText("example.com##filter1");
   let subdomainFilter = Filter.fromText("www.example.com##filter2");
   let otherDomainFilter = Filter.fromText("other.example.com##filter3");
 
   ElemHideEmulation.add(domainFilter);
   ElemHideEmulation.add(subdomainFilter);
@@ skipping 13 matching lines @@
 
   ElemHideEmulation.clear();
   compareRules(
     "Return no filters after clearing",
     "www.example.com",
     []
   );
 
   test.done();
 };