Issue 5143 - Convert ElemHideEmulation to C++

test/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 65 matching lines @@
   test.equal(selectors.selectorAt(1), ".foo");
   test.equal(selectors.filterKeyAt(1), "example.com##.foo");
   selectors.delete();
 
   let filter3 = Filter.fromText("example.com##.message");
   ElemHide.add(filter3);
   selectors = ElemHide.getSelectorsForDomain("example.com", 0);
   test.equal(selectors.selectorCount, 3);
   selectors.delete();
   selectors = ElemHide.getSelectorsForDomain("mail.example.com", 0);
   test.equal(selectors.selectorCount, 3);

[sergei, 2018/01/25 16:04:01]

IMO it would be better to check the actually returned selectors than merely the
size of the list.

[hub, 2018/01/25 19:05:27]

Done. (in the whole test, not just here).

   selectors.delete();
 
   let filter4 = Filter.fromText("mail.example.com#@#.message");
   ElemHide.add(filter4);
   selectors = ElemHide.getSelectorsForDomain("example.com", 0);
   test.equal(selectors.selectorCount, 3);
   selectors.delete();
   selectors = ElemHide.getSelectorsForDomain("mail.example.com", 0);
   test.equal(selectors.selectorCount, 2);
   selectors.delete();
@@ skipping 26 matching lines @@
   {
     for (let text of filters)
     {
       let filter = Filter.fromText(text);
       if (filter instanceof ElemHideEmulationFilter)
         ElemHideEmulation.add(filter);
       else
         ElemHide.add(filter);
       filter.delete();
     }
-    let matches = ElemHideEmulation.getRulesForDomain(domain)
-        .map(filter => filter.text);
+
+    let rules = ElemHideEmulation.getRulesForDomain(domain);
+    let matches = [];
+    for (let i = 0; i < rules.filterCount; i++)
+    {
+      let filter = rules.filterAt(i);
+      matches.push(filter.text);
+      filter.delete();
+    }
     test.deepEqual(matches.sort(), expectedMatches.sort(), description);
+    rules.delete();
 
     ElemHideEmulation.clear();
     ElemHide.clear();
   }
 
   testSelectorMatches(
     "Ignore generic filters",
     [
       "##[-abp-properties='foo']", "example.com##[-abp-properties='foo']",
       "~example.com##[-abp-properties='foo']"
@@ skipping 38 matching lines @@
     ["other.example.com##[-abp-properties='foo']"]
   );
 
   test.done();
 };
 
 exports.testElemHideEmulationFiltersContainer = function(test)
 {
   function compareRules(description, domain, expectedMatches)
   {
-    let result = ElemHideEmulation.getRulesForDomain(domain)
-        .map(filter => filter.text);
+    let rules = ElemHideEmulation.getRulesForDomain(domain);
+    let result = [];
+    for (let i = 0; i < rules.filterCount; i++)
+    {
+      let filter = rules.filterAt(i);
+      result.push(filter.text);
+      filter.delete();
+    }
     expectedMatches = expectedMatches.map(filter => filter.text);
     test.deepEqual(result.sort(), expectedMatches.sort(), description);
+
+    rules.delete();
   }
 
   let domainFilter = Filter.fromText("example.com##filter1");
   let subdomainFilter = Filter.fromText("www.example.com##filter2");
   let otherDomainFilter = Filter.fromText("other.example.com##filter3");
 
   ElemHideEmulation.add(domainFilter);
   ElemHideEmulation.add(subdomainFilter);
   ElemHideEmulation.add(otherDomainFilter);
   compareRules(
@@ skipping 11 matching lines @@
 
   ElemHideEmulation.clear();
   compareRules(
     "Return no filters after clearing",
     "www.example.com",
     []
   );
 
   test.done();
 };